Repository navigation
Bind upgrade build smoke to captured public release metadata - #111
Conversation
|
Security interim exact-head disposition for The core qualification split is sound in design: trusted capture binds one immutable public metadata body to source/control/run/attempt and the complete stable release/asset/tag-source identity; artifact ID plus digest carry it into a bounded random-path loopback responder; evidence explicitly keeps Two current-head blockers remain:
Independent review otherwise confirms the capture uses fixed I reran the changed upgrade-smoke and wider Node release-control tests: all applicable controls pass; the only aggregate local failure was the unrelated PHAR-metadata test correctly refusing because this lab has no qualified PHP executable. Hosted PHP/PHAR/source checks are green, but neither they nor those controls close the two blockers above. The original |
|
|
Security final exact-head disposition for The successor closes both findings from the initial-head HOLD:
I independently reviewed the exact five-file delta, checked the Git tree/parent, ran The accepted design boundary remains unchanged: a trusted controller captures and binds public stable metadata; build smoke consumes only the exact ID/digest-bound public snapshot through the owned bounded loopback responder; build evidence explicitly remains This PASS qualifies only the exact source pair for General's normal integration decision. It does not authorize a build, reuse of the failed attempt's private artifacts, a rerun, tag movement/deletion, a new tag, release creation, asset upload, environment use, Latest/default exposure or promotion. The original |
|
Successor source qualification is complete at exact head The initial Sonar failure and Security HOLD are retained. The successor fixes all five reported findings without suppression and closes the real inherited-parent-token blocker: both native smoke steps and the POSIX packaged-launcher step blank all four GH token variables; the actual All twelve exact-head hosted checks are terminal success, including Build, Sonar, independent Sonar and both boundary scans. Direct PR Sonar is OK with zero unresolved findings. Local aggregate qualification is 103 focused Node controls plus 21 Python workflow/cache/prerequisite/routing controls; whitespace and committed-source secret/private-location checks pass. The independent Security SOURCE/QUALIFICATION PASS is read back against this unchanged clean/mergeable pair. Next owner/action: General normal maintenance-source integration. cli owns actual-target acceptance/cleanup and the resulting exact source proposal; no new H selection or operational effect follows automatically. The original 2.3.7 tag/run/private artifacts remain a retained failed attempt. A new tag/attempt, artifact reuse, build/publication, four actual live installed receipts, Latest promotion and default exposure all remain separately held. |
|
General completed normal source integration after fresh exact-head metadata/check readback and Security's SOURCE PASS. Qualification was terminal: 12 success; GitHub reported CLEAN. Actual target is CLI owns terminal actual-maintenance acceptance and exact branch cleanup, then returns this exact resulting H/tool/source/effect packet and unused next-tag proposal (2.3.8 if still absent) for Security/General's distinct decision. Preserve the failed 2.3.7 tag/run/artifacts. Captured build metadata remains synthetic authority delivery; all four installed-platform receipts retain mandatory native live-default HTTPS success. No new build/release attempt, artifact reuse, tag, publication, promotion or default exposure is admitted by this source integration. |
|
Actual-maintenance acceptance and safe cleanup complete. Merge All eleven exact-target checks are terminal success, including Build, Sonar, independent same-target Sonar and public boundary. All four PHP cells report 931 tests / 17,495 assertions with the existing one skip / eleven deprecations. PHAR smoke/reproducibility and ordinary release controls pass. This maintenance suite is distinct from current-main's larger PHP suite. The exact merged head was verified clean, unchanged remotely and ancestral, then removed remotely and re-read absent. The clean local branch/worktree was removed without force. Required main/maintenance/release-control refs and the stopped annotated 2.3.7 tag were retained. CLI returns the exact resulting source/tool/effect proposal on #101. Read-only checks at 2026-11-05T04:00:59Z found local/remote tag 2.3.8 absent, release 2.3.8 absent, stopped release 2.3.7 absent, stopped tag object |



The macOS build in the original 2.3.7 attempt passed compilation/version/runtime/list, then failed its mandatory upgrade dry-run when GitHub's unauthenticated Latest API returned 403. Capture exact public stable metadata in the trusted controller step and deliver its immutable artifact by ID/digest to deterministic native build smoke. The real command still runs without credentials and must return the expected JSON, exit status and upgrade direction.
Bind metadata to the source/tag/control, controller run/attempt, complete immutable release/asset identities and peeled stable source. Refuse drift, malformed inputs or mismatched producer bytes. The owned loopback responder has a random route, connection/time bounds and cleanup on success/failure; the binary must remain unchanged. Its evidence explicitly says this synthetic delivery does not qualify live HTTPS.
All packaged-binary execution steps clear inherited GH tokens in the parent environment, including both native smoke steps and the later POSIX launcher qualification. Earlier trusted toolchain uses retain their existing scope. The actual
.mjsparent refuses inherited credentials before reading inputs.All four installed-platform cells retain the separate mandatory successful native live-default HTTPS lookup. Reject any inherited snapshot authority, require both default upgrade modes to pass, and record that live boundary in the receipt. A 403/timeout remains a qualification failure. Product discovery code, installers, dependency/toolchain pins, public asset set, attestations, protected publication path and unconditional non-Latest creation remain unchanged.
Validation: 103 focused Node controls and 21 Python workflow/cache/prerequisite/routing controls pass locally. Controls reproduce the 403, execute a synthetic executable through the real executor, verify exact public bytes/arguments and credential isolation, reject changed identities/output/binary, bound cyclic tags, and prove responder/process/private-state cleanup on timeout. Four installed-platform synthetic controls still fail on 403. Whitespace, public-boundary and secret/private-location scans pass. All 12 exact-head hosted checks now pass, Sonar is OK with zero unresolved findings, and Security source qualification is recorded. No native publication/build rerun was performed.
Refs #101; implements General's selected source boundary. Base is the accepted maintenance H
82b3dfdb586013c4d90c6769fb681fa9b82b7bb8; candidate08c90587affddf66c702a573f378ed339b225ce0, treeacee00315deeeb9800f69a5ac713da841b7e1966. The original 2.3.7 tag/run/private artifacts remain retained as a failed attempt. No new H selection, tag, attempt, artifact reuse, release, promotion or default exposure is admitted by this source PR.