Prevent crash if there was an exception getting login items for URL#8166
Merged
CrisBarreiro merged 1 commit intodevelopfrom Apr 7, 2026
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
|
@CrisBarreiro i'm still seeing it crash with the patch applied |
CDRussell
approved these changes
Apr 1, 2026
Member
There was a problem hiding this comment.
Discussed #8166 (comment)
- it does still crash because something else is accessing autofill in that scenario which isn't going through the protected path changed in this PR (basically, ignoring the patch it's a fine change)
- longer term, we want to return
Resultto better encapsulate the more nuanced return types but making this one narrow part safer (this PR) is a good start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1203822806345703/task/1213886927706691?focus=true
Description
Steps to test this PR
Feature 1
Patches
UI changes
Note
Low Risk
Low risk: change is localized to
getCredentialsand only alters error handling by returning an empty result on unexpected exceptions while preserving coroutine cancellation.Overview
Prevents crashes during autofill credential lookup by wrapping
SecureStoreBackedAutofillStore.getCredentialssecure-storage reads/filtering inrunCatching.On failure it now calls
ensureActive()(so cancellations still propagate) and returns an empty credentials list instead of throwing.Written by Cursor Bugbot for commit c626e49. This will update automatically on new commits. Configure here.