Repository navigation
fix: support type parameters on arrow functions - #1692
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
Author
|
Could a maintainer approve the pending CI run when convenient? The local package tests, Node and Deno builds, type checks and formatting passed, as documented in the PR description. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the first type parameters to an arrow function throws
NotImplementedError. Insert them before the parameter list, adding parentheses around a bare parameter when needed. Preserve cached parameter and identifier nodes so later renames still work.Single type parameters in TSX get a trailing comma to avoid being parsed as JSX. Regressions cover ordinary and async arrows, comments, existing generics, TSX, cached-node renames, and unchanged input for empty additions or invalid indices.
Fixes #1680.
Validation on TypeScript 6.0.2: