Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1632.
String literals in array elements and call arguments were skipped by getChildrenOfKind because the lookup treated StringLiteral as a token that needed direct token children. Search the parse tree for this kind so the child and first/last child getters find those literals, while preserving syntax-list lookup and descendant order.
Tests cover array elements, call arguments, syntax lists, first/last child getters, and nested descendants. Three focused regressions fail without the fix and pass with it. The final ts-morph suite passes with 4,388 tests and 2 pending on TypeScript 6.0.2. Project compile, code verification, formatting, and the Node bundle build pass.
The TypeScript-version matrix and Deno/browser builds were not run locally. The Deno-hosted setup build emitted its bundle but did not exit; the same package Rollup configuration completed successfully under Node.
No new dependencies or public signatures.