Skip to content

fix(shaderdebugger): wire Refresh All to reload tracked shaders#604

Merged
drsnuggles8 merged 1 commit into
masterfrom
feature/shaderdebugger-refresh-594
Jul 10, 2026
Merged

fix(shaderdebugger): wire Refresh All to reload tracked shaders#604
drsnuggles8 merged 1 commit into
masterfrom
feature/shaderdebugger-refresh-594

Conversation

@drsnuggles8

Copy link
Copy Markdown
Owner

Summary

  • The Shader Debugger panel's "Refresh All" button was a no-op TODO.
  • Wires it to ShaderLibrary::ReloadShaders() for both Renderer3D and Renderer2D's shader libraries — the same reload path (Shader::Reload()) used by the filewatch hot-reload, and already exposed via Lua/C# scripting (ShaderLibrary3D_ReloadAll / ShaderLibrary2D_ReloadAll) and the olo_shader_reload MCP tool, so this matches established convention rather than introducing a new one.
  • Compile errors surface identically to the automatic hot-reload path, via the existing OnCompilationEnd/OnReloadEnd ShaderDebugger hooks.

Fixes #594

Test plan

The Shader Debugger panel's "Refresh All" button was a no-op TODO.
Wire it to ShaderLibrary::ReloadShaders() for both the 3D and 2D
shader libraries — the same reload path (Shader::Reload()) used by
the filewatch hot-reload and already exposed to Lua/C# scripting and
the olo_shader_reload MCP tool, so compile errors surface identically
via the existing OnCompilationEnd/OnReloadEnd hooks.

Fixes #594

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@drsnuggles8, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 93de18ce-6370-4171-bf7e-066f058a2daf

📥 Commits

Reviewing files that changed from the base of the PR and between 5a027f5 and f4db6dc.

📒 Files selected for processing (1)
  • OloEngine/src/OloEngine/Renderer/Debug/ShaderDebugger.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@drsnuggles8 drsnuggles8 merged commit 7d8be18 into master Jul 10, 2026
11 checks passed
@drsnuggles8 drsnuggles8 deleted the feature/shaderdebugger-refresh-594 branch July 10, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShaderDebugger: wire up "Refresh All" to actually reload shaders

1 participant