[#2562] Added Gitleaks secret scanning to CI lint jobs.#2579
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 34 minutes and 2 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (57)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
- Coverage 86.56% 86.11% -0.46%
==========================================
Files 94 87 -7
Lines 4661 4502 -159
Branches 47 3 -44
==========================================
- Hits 4035 3877 -158
+ Misses 626 625 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
CONFLICT
AlexSkrypnyk
force-pushed
the
feature/2562-gitleaks-scan
branch
from
55dcc30 to
bb7a690
Compare
github-actions
Bot
removed
the
CONFLICT
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2562
Summary
Added Gitleaks secret scanning to the
lintjob in both GitHub Actions and CircleCI. A.gitleaks.tomlconfig ships with the template, extending the default Gitleaks ruleset and allowlisting third-party, generated, and local-only paths (vendor, node_modules, web/core, web/modules/contrib, web/themes/contrib, web/libraries, web/sites/default/files, .data, .artifacts, .git, .vortex) so a clean Vortex install reports zero findings while still catching real committed secrets. The step follows the same bypass-variable pattern (VORTEX_CI_GITLEAKS_IGNORE_FAILURE) used by all other containerised scanners in Vortex.Changes
CI integration
build-test-deploy.yml): new "Scan for committed secrets with Gitleaks" step in thelintjob after DCLint, runningghcr.io/gitleaks/gitleaks:v8.30.1 dir . --no-banner; respectsVORTEX_CI_GITLEAKS_IGNORE_FAILUREviacontinue-on-error.config.yml): equivalent step after DCLint, using the|| [ "${VORTEX_CI_GITLEAKS_IGNORE_FAILURE:-0}" -eq 1 ]bypass pattern.Configuration
.gitleaks.toml(new, ships to consumers): extendsuseDefault = trueand declares a single allowlist covering the standard Drupal/Vortex ignored paths. Tuned to produce zero false positives on a clean install.Documentation
.vortex/docs/content/tools/gitleaks.mdxtool page covering usage, per-line ignoring (gitleaks:allow), path-level ignoring via.gitleaks.toml, and theVORTEX_CI_GITLEAKS_IGNORE_FAILUREvariable..vortex/docs/content/tools/README.mdx.gitleaksandtomlto.vortex/docs/cspell.json.Tests
.vortex/installer/tests/Fixtures/handler_process/to include the new.gitleaks.tomlin the_baselinesnapshot and the relevant scenario outputs (132/132 scenarios passing).Scope notes
The original issue also requested SARIF upload to GitHub code scanning (Security tab) and a sticky PR comment summarising findings. These were intentionally descoped: Vortex's CI lint jobs use a simple pass/fail check with a
VORTEX_CI_GITLEAKS_IGNORE_FAILUREbypass, consistent with how Hadolint, DCLint, and the other containerised scanners are integrated. Adding SARIF upload or PR annotations would diverge from that pattern and can be revisited as a follow-up if wanted.Before / After