[#2545] Removed stale cloned ScriptHandler.php and its composer wiring.#2578
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 87 minutes and 38 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (21)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
- Coverage 86.56% 86.11% -0.45%
==========================================
Files 94 87 -7
Lines 4660 4502 -158
Branches 47 3 -44
==========================================
- Hits 4034 3877 -157
+ Misses 626 625 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
changed the title
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2545
Summary
scripts/composer/ScriptHandler.phpwas a near-verbatim clone ofdrupal-composer/drupal-projectcarrying assumptions that no longer match Vortex: aconfig/syncconfig-sync-directory path (Vortex usesconfig/default), an obsoletecheckComposerVersion()Composer 1 gate with a misleading "we do not ship with a lock file" docblock, and a deadsettings.php-creation branch (Vortex commits its ownweb/sites/default/settings.php). Once the dead logic was stripped, the only behavior left was creatingweb/modules/web/profiles/web/themes(already committed in the template) and the gitignoredweb/sites/default/filesdirectory (which Drupal creates during site install/provision anyway). With nothing load-bearing remaining, the file is removed outright.Changes
scripts/composer/ScriptHandler.php.composer.json: removed thescriptssection (thepre/post-install/update-cmd events) and theautoloadclassmap that pointed at the file.autoload-devis unchanged..vortex/docs/content/drupal/composer-json.mdx: removed the### scriptsand### autoloadsubsections that documented the removed wiring.ScriptHandler.phpfixtures (baseline plus thetools_no_phpcs*/tools_none/tools_groups_no_be_lint*variants) and updates thecomposer.jsonfixtures.Notes
webflo/drupal-finderstays inrequire- it is still used byrector.php.web/sites/default/filesis no longer created atcomposer installtime. That directory is gitignored and is created by Drupal during site install/provision, so the end-to-endvortex-test-workflowCI jobs (which build and provision a real site) are the backstop confirming nothing relies on the composer-time creation.