[#2546] Made the Lagoon amazee.io trusted-host region configurable.#2577
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (1)
WalkthroughAdds VORTEX_LAGOON_AMAZEEIO_REGION to ChangesLagoon amazee.io Region Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 86.56% 86.11% -0.45%
==========================================
Files 94 87 -7
Lines 4660 4502 -158
Branches 47 3 -44
==========================================
- Hits 4034 3877 -157
+ Misses 626 625 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Closes #2546
Summary
The Lagoon settings file hardcoded the Australian amazee.io region (
^.+\.au\.amazee\.io$) intrusted_host_patterns, forcing consumers on other amazee.io regions to edit a block marked "do not modify" and leaving everyone with a broad wildcard for a region they may not use. This makes the region configurable via a newVORTEX_LAGOON_AMAZEEIO_REGIONvariable that defaults toau, so existing behavior is byte-identical, while other regions can be selected and projects that do not run on amazee.io can opt out entirely.Changes
Lagoon settings (
web/sites/default/includes/providers/settings.lagoon.php)^.+\.au\.amazee\.io$pattern with a block driven byVORTEX_LAGOON_AMAZEEIO_REGION.au, producing the exact same pattern as before (no regression).preg_quote()before being embedded in the pattern, matching the escaping already used in the siblingsettings.trusted_hosts.php.Configuration and docs
VORTEX_LAGOON_AMAZEEIO_REGION=auto theHOSTING_LAGOONblock in.env, next toVORTEX_LAGOON_PRODUCTION_BRANCH, giving consumers a discoverable override point..env)..envchanges.Before / After
Summary by CodeRabbit
New Features
Documentation