Repository navigation
fix: probe for an executable at a relative dprint.path on Windows - #189
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
dprint.pathsetting like.vscode/dprintno longer working on Windows when there's a.vscode/dprint.batbeside a.vscode/dprintshell script for other platforms (see dprint/dprint#859 (comment)). This regressed in #163 when dprint started being launched without cmd.exe where possible.dprint.pathcontaining a path separator (ex..vscode/dprintorbin\dprint) is now resolved against the folder on Windows. Previously only paths starting with./or../were, so others were searched for relative to the extension host's cwd.PATHEXTextensions (.exe,.com,.cmd,.bat) are now probed before the path itself, like cmd.exe does. Previously the extensionless file won when it existed, which can't be launched when it's a shell script. This also helps$(yarn bin dprint), which resolves to anode_modules/.bin/dprintscript beside adprint.cmd.Command names such as
dprintare still searched for on the path as before and nothing changes on macOS and Linux.