ci+scripts: copilot toolchain cache + Test262 feature-gap tool#460
Conversation
The toolchain cache pattern (cache restore → conditional install → unconditional PATH) was added to unit-test, test262, regression-check, bench, and startup-hyperfine, but copilot-setup-steps.yml still used the original unconditional curl | bash path. Apply the same three-step split here with a job-level env block carrying MOONBIT_CACHE_VERSION so the key can be busted on demand. Closes #292 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 43 minutes and 29 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add scripts/test262_feature_gap.py, a non-authoritative planning tool that compares this repo's skip metadata (scripts/test262_skip_metadata.json) against an external Test262 feature config's [features] section. The report has three sections: - Features we skip that the external config runs (planning priority signal) - Features both configs skip - Features the external config runs that we also run The script makes no conformance claims and emits no pass-rate numbers. A non-authoritative disclaimer appears at the top of every generated report. Also added: - scripts/test_test262_feature_gap.py: 15 Python unit tests covering the config parser and report builder (all passing) - Makefile targets: test262-feature-gap (requires EXT_CONFIG=) and test262-feature-gap-test (runs the Python unit tests) - docs/TEST262.md: "Feature gap report" section documenting usage Closes #234 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dowdiness
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7464065c9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…234) External configs like QuickJS's test262.conf use `feature=skip` inside [features] to mark unsupported features. The old parser treated the whole token as a feature name, placing `BigInt=skip` in the "external config runs" set and causing materially misleading planning reports. parse_features_config now returns (runs, skips): bare tokens go to runs, `feature=skip` entries go to skips. build_report splits the "both skip" section into two sub-sections: explicitly skipped by external vs not mentioned. 23 tests (up from 15), including a regression test for the =skip misclassification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
Summary
Commit 1: ci: cache MoonBit toolchain in copilot-setup-steps
Issue #292 (toolchain caching) was implemented in PR #295 for
unit-test,test262,regression-check,bench, andstartup-hyperfinejobs.copilot-setup-steps.ymlwas the only remaining workflow still using the unconditionalcurl | bashinstall path. Applies the same three-step pattern (cache restore → conditional install → unconditional PATH registration).Commit 2: feat(scripts): Test262 feature-gap comparison tool
Adds
scripts/test262_feature_gap.py— a non-authoritative planning tool that compares this repo's skip metadata against an external Test262 feature config's[features]section. Produces a Markdown report with three sections: features we skip that the external config runs, features both configs skip, and features both run. No pass rates or conformance claims.Also adds:
scripts/test_test262_feature_gap.py: 15 Python unit tests (all passing)test262-feature-gapandtest262-feature-gap-testdocs/TEST262.md"Feature gap report" sectionTest plan
make test262-feature-gap-testpasses (15 Python unit tests)python3 scripts/test262_feature_gap.py --ext-config <file>produces readable Markdown outputCloses #234
Closes #292
🤖 Generated with Claude Code