Skip to content

Update Windows 2022 CI images #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nagilson merged 7 commits into from
Sep 28, 2026
Merged

Update Windows 2022 CI images #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d02f616
Initial plan
Copilot Sep 25, 2026
21d6bbe
Update Windows CI images
Copilot Sep 25, 2026
15a9f1c
Use current Windows 2022 CI images
Copilot Sep 25, 2026
237ecf9
Apply remaining changes
Copilot Sep 25, 2026
350c97a
Use VS 2026 images without Bash
Copilot Sep 28, 2026
702e9c6
Restore Bash with VS 2026 setup
Copilot Sep 28, 2026
2bf3c26
Apply remaining changes
Copilot Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions 1es-azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ parameters:
type: object
default:
- name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
emoji: 🪟
- name: NetCore1ESPool-Internal
Expand All @@ -65,7 +65,7 @@ extends:
sdl:
sourceAnalysisPool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
policheck:
enabled: true
Expand Down Expand Up @@ -99,14 +99,14 @@ extends:
parameters:
pool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
useOneEngineeringPool: true
- template: pipeline-templates/package-vsix.yaml@self
parameters:
pool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
useOneEngineeringPool: true
SignType: Real
Expand All @@ -115,6 +115,6 @@ extends:
parameters:
pool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
useOneEngineeringPool: true
6 changes: 3 additions & 3 deletions 1pr-azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ parameters:
type: object
default:
- name: NetCore-Public
demands: ImageOverride -equals 1es-windows-2022-open
demands: ImageOverride -equals windows.vs2026.amd64.open
Comment thread
nagilson marked this conversation as resolved.
os: windows
emoji: 🪟
- name: NetCore-Public
Expand Down Expand Up @@ -64,14 +64,14 @@ stages:
parameters:
pool:
name: NetCore-Public
demands: ImageOverride -equals 1es-windows-2022-open
demands: ImageOverride -equals windows.vs2026.amd64.open
os: windows
useOneEngineeringPool: false
- template: pipeline-templates/package-vsix.yaml
parameters:
pool:
name: NetCore-Public
demands: ImageOverride -equals 1es-windows-2022-open
demands: ImageOverride -equals windows.vs2026.amd64.open
os: windows
useOneEngineeringPool: false
SignType: Test
12 changes: 11 additions & 1 deletion pipeline-templates/install-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,14 @@ steps:
- task: UseNode@1
inputs:
version: '22.x'
displayName: '⚛️ Install Node.js'
displayName: '⚛️ Install Node.js'
- script: corepack enable && corepack install --global yarn@1.22.22
displayName: '🧶 Install Yarn'

@JoeRobich JoeRobich Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we getting value out of using yarn instead of npm? Seems like it adds complexity.

@nagilson nagilson Sep 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, I forget why we did this and things might have changed but there is some NPM limitation that made it nonfunctional, at least 2 years ago. We have to use npm too because yarn doesnt have support for vsts auth. CDK does the same thing, unless things changed.

@nagilson nagilson Sep 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#617 outlines why, it mentions there's a VSCE limitation where it required yarn and didn't work with npm. I think it has to do with the multi-folder layout we use but not quite remember. I'm pretty sure I explained this in more detail in a comment somewhere.

- pwsh: |
$gitBashDirectory = Join-Path $env:ProgramFiles 'Git\bin'
if (-not (Test-Path (Join-Path $gitBashDirectory 'bash.exe'))) {
throw "Unable to locate Git Bash in $gitBashDirectory."
}
Write-Host "##vso[task.prependpath]$gitBashDirectory"
displayName: '🐚 Add Git Bash to PATH'
condition: eq(variables['Agent.OS'], 'Windows_NT')
4 changes: 2 additions & 2 deletions release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extends:
parameters:
pool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
customBuildTags:
- ES365AIMigrationTooling
Expand All @@ -37,7 +37,7 @@ extends:
environment: vscode-dotnetcore-extension-releases
pool:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
image: windows.vs2026.amd64
os: windows
templateContext:
type: releaseJob
Expand Down
Loading
Loading