[iOS] Enabled RefreshControl for large Titles #33181
Open
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where RefreshControl did not appear correctly on iOS when used with large-title navigation bars. The fix simplifies the implementation by always using direct subview insertion instead of conditionally using the RefreshControl property.
Key Changes
- Removed conditional logic based on
NavigationBar.PrefersLargeTitles - Always use
InsertSubviewto add the refresh control to scrollable views - Always set
RefreshControl = nullduring cleanup for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33169
Changes
UIRefreshControlviascrollView.RefreshControl = nullwhen removing it, simplifying cleanup.UIScrollViewinstead of using theRefreshControlproperty, avoiding large-title navigation bar interference.CanUseRefreshControlPropertyhelper tied toNavigationBar.PrefersLargeTitles, eliminating the conditional path that hid the control.Rationale
RefreshControlproperty. Direct insertion ensures the control remains visible and usable.Screen.Recording.2025-12-15.at.20.37.27.mov
Screen.Recording.2025-12-15.at.20.40.41.mov