Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyModel;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Options;

namespace Microsoft.AspNetCore.Mvc.Testing;

Expand Down Expand Up @@ -588,7 +589,16 @@ private static void EnsureDepsFile()
/// </summary>
/// <param name="serviceProvider">The <see cref="IServiceProvider"/> from the bootstrapped application.</param>
/// <returns></returns>
protected virtual TestServer CreateServer(IServiceProvider serviceProvider) => new(serviceProvider);
protected virtual TestServer CreateServer(IServiceProvider serviceProvider)
{
var options = serviceProvider.GetService<IOptions<TestServerOptions>>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should instead change the TestServer ctor to try getting the options?

: this(services, featureCollection, Options.Create(new TestServerOptions()))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wondered also myself but I assume there was a good reason to not do it initially and now it could be considered as a breaking change, no?

if (options is not null)
{
return new(serviceProvider, options);
}

return new(serviceProvider);
}

/// <summary>
/// Creates the <see cref="IHost"/> with the bootstrapped application in <paramref name="builder"/>.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Net;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.AspNetCore.TestHost;

namespace Microsoft.AspNetCore.Mvc.FunctionalTests;

public class CustomWebApplicationFactory : WebApplicationFactory<SimpleWebSite.Startup>
{
public Action<TestServerOptions> ConfigureOptions { get; set; }

protected override void ConfigureWebHost(IWebHostBuilder builder)
{
builder.UseTestServer(ConfigureOptions);
}
}

public class TestServerWithCustomConfigurationIntegrationTests : IClassFixture<CustomWebApplicationFactory>
{
public CustomWebApplicationFactory Factory { get; }

public TestServerWithCustomConfigurationIntegrationTests(CustomWebApplicationFactory factory)
{
Factory = factory;
}

[Fact]
public async Task ServerConfigured()
{
// Arrange
var optionsConfiguredCounter = 0;
Factory.ConfigureOptions = options =>
{
options.AllowSynchronousIO = true;
options.PreserveExecutionContext = true;
optionsConfiguredCounter++;
};

// Act
Assert.Equal(0, optionsConfiguredCounter);
Factory.StartServer();

using var client = Factory.CreateClient();

using var response = await client.GetAsync("/");

// Assert
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Equal(1, optionsConfiguredCounter);
Assert.True(Factory.Server.AllowSynchronousIO);
Assert.True(Factory.Server.PreserveExecutionContext);
}
}
Loading