Suppress JSDisconnectedException in IJSObjectReference.DisposeAsync #64773
+60
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress JSDisconnectedException in IJSObjectReference.DisposeAsync
Catch and discard JSDisconnectedException during JS object disposal
Description
When a circuit disconnects (user navigates away, closes tab, or full-page reload), components disposing
IJSObjectReferenceinstances throwJSDisconnectedException. This forces developers to wrap disposal in try-catch blocks.Changes:
JSObjectReference.DisposeAsync()to catch and suppressJSDisconnectedExceptionRationale:
If JS is disconnected, the JS-side object is already gone. Server-side disposal would fail regardless, so the exception provides no value and only creates noise.
Before:
After:
Original prompt
This section details on the original issue you should resolve
<issue_title>Change IJSObjectReference.Dispose specifically so that it deals with catching and discarding JSDisconnectedException internally</issue_title>
<issue_description>I'm getting a warning and exception when trying to dispose a JavaScript module reference in a component's DisposeAsync method when the component is using the server interactive render mode.
Repro steps:
Expected result: No exception
Actual result: JSDisconnectedException