Implement dispose pattern for InputFile #64771
Draft
+54
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dispose pattern for InputFile
Implement standard .NET dispose pattern in InputFile
Description
InputFilepreviously used explicit interface implementation forIDisposable.Dispose(), making it difficult for derived classes to properly dispose resources without reflection. Now implements the standard dispose pattern with a protected virtual method.Changes:
protected virtual void Dispose(bool disposing)method containing disposal logicIDisposable.Dispose()to callDispose(true)Pattern follows:
Derived classes can now override
Dispose(bool)without reflection, consistent withInputBaseandValidationMessage.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.