Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Dec 17, 2025

This PR intended to fix issue that package-icon.png file is shown on all projects on Solution Explorer.
It's caused by following setting that defined on build/common.props.

  <ItemGroup>
    <None Include="$(MSBuildThisFileDirectory)package-icon.png" Pack="True" PackagePath=""/>
  </ItemGroup>

What's changed in this PR

  1. Add build/common.targets file and move following setting that require MSBuild property that defined at project level
      <ItemGroup Condition="'$(IsPackable)' == 'true'">
        <None Include="$(MSBuildThisFileDirectory)package-icon.png" Pack="True" PackagePath=""/>
      </ItemGroup>
    
  2. Add setting to import build\common.targets on existing projects.

Other Changes

1. BenchmarkDotNet.slnx
Add settings to show props/targets files on SolutionExplorer

2. build/common.props

  • Add condition to check GenerateDocumentationFile property is defined or not.
    (It's required to use custom setting on Directory.Build.props)
  • Modify VB/F# project detection logics. (VB logic is removed because it works without warnings).
  • Replace dev dependencies to use GlobalPackageReference,

3. samples/common.props
4. tests/common.props
Add setting to set following properties

    <GenerateDocumentationFile>false</GenerateDocumentationFile>
    <IsPackable>false</IsPackable>

5. BenchmarkDotNet.IntegrationTests.FSharp.vbproj
6. BenchmarkDotNet.IntegrationTests.VisualBasic.vbproj
Remove custom MSBuild property that is not used.

@filzrev filzrev force-pushed the chore-add-common-targets branch from b402111 to c92ecd1 Compare December 17, 2025 09:43
@filzrev filzrev force-pushed the chore-add-common-targets branch from c92ecd1 to 0547648 Compare December 17, 2025 10:51
@filzrev
Copy link
Contributor Author

filzrev commented Dec 17, 2025

CI build failed on ubuntu-latest that caused by GenerateDocumentationFile setting.
I'll check failure reason later.

-> It seems existing Directory.build.props file name name is wrong.
And it's not recognized as valid props file on linux environment.

Co-authored-by: Tim Cassell <[email protected]>
@timcassell timcassell merged commit 047b95d into dotnet:master Dec 21, 2025
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants