Skip to content

PauseMenu2 matching and naming.#114

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
CaptainProton42:PauseMenu2
Jun 21, 2026
Merged

PauseMenu2 matching and naming.#114
Mrkol merged 1 commit into
doldecomp:mainfrom
CaptainProton42:PauseMenu2

Conversation

@CaptainProton42

Copy link
Copy Markdown
Contributor

Lots of matching progress, except for stack space, but some sections still have incorrect register usage or out of order instructions.

Some inlines are also a bit dodgy probably.

I've verified the usage and naming of class members by inspecting memory at runtime in an emulator.

@decomp-dev

decomp-dev Bot commented Jun 20, 2026

Copy link
Copy Markdown

Report for GMSJ01 (9afb31a - 41a8e85)

📈 Matched code: 32.40% (+0.04%, +1364 bytes)
📈 Matched data: 42.65% (+0.05%, +308 bytes)

✅ 8 new matches
Unit Item Bytes Before After
mario/GC2D/PauseMenu2 __sinit_PauseMenu2_cpp +764 0.00% 100.00%
mario/GC2D/PauseMenu2 TPauseMenu2::TPauseMenu2(const char*) +276 0.00% 100.00%
mario/GC2D/PauseMenu2 TPauseMenu2::getNextState() +192 0.00% 100.00%
mario/GC2D/PauseMenu2 .bss +184 0.00% 100.00%
mario/GC2D/PauseMenu2 .rodata +120 0.00% 100.00%
mario/GC2D/PauseMenu2 TPauseMenu2::~TPauseMenu2() +116 0.00% 100.00%
mario/GC2D/PauseMenu2 JGeometry::TVec3<float>::set<float>(float, float, float) +16 0.00% 100.00%
mario/GC2D/PauseMenu2 .ctors +4 0.00% 100.00%
📈 10 improvements in unmatched items
Unit Item Bytes Before After
mario/GC2D/PauseMenu2 TPauseMenu2::perform(unsigned long, JDrama::TGraphics*) +2351 0.00% 99.28%
mario/GC2D/PauseMenu2 TPauseMenu2::disappearWindow() +1060 0.00% 99.27%
mario/GC2D/PauseMenu2 TPauseMenu2::appearWindow() +949 0.00% 99.70%
mario/GC2D/PauseMenu2 TPauseMenu2::load(JSUMemoryInputStream&) +800 0.00% 98.16%
mario/GC2D/PauseMenu2 TPauseMenu2::loadAfter() +591 0.00% 99.89%
mario/GC2D/PauseMenu2 TPauseMenu2::drawAppearPane(J2DPicture*, float, JUTRect&, float) +532 0.00% 96.53%
mario/GC2D/PauseMenu2 TPauseMenu2::setDrawStart() +462 0.00% 99.72%
mario/GC2D/PauseMenu2 .sdata2 +211 0.00% 98.00%
mario/GC2D/PauseMenu2 TPauseMenu2::setDrawEnd() +87 0.00% 99.77%
mario/GC2D/PauseMenu2 .data +76 0.00% 21.35%

@Mrkol Mrkol merged commit fc29523 into doldecomp:main Jun 21, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants