Replace raw 0x10 with JOBJ_HIDDEN in HSD_JObj flag calls#2675
Merged
Conversation
Syntax-aware sweep of HSD_JObj{Set,Clear}Flags[All] call sites replacing
raw hidden-flag literals (0x10 / 0x10U / 16 / 16U) in the flag argument
with the named JOBJ_HIDDEN: 505 sites across 73 files. Composite masks
and other flag values are untouched.
All 1046 compiled objects verified byte-identical before and after the
change (per-object sha1); main.dol sha1 unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jun 13, 2026
itsgrimetime
added a commit
to itsgrimetime/melee
that referenced
this pull request
Jun 14, 2026
--fix rewrites source in place to resolve jobj-flags findings locally (--fix --dry-run previews a unified diff): the raw hidden-flag literal is replaced with JOBJ_HIDDEN. The swap is exact — verified to reproduce the doldecomp#2675 sweep content byte-for-byte across all 73 files (modulo clang-format line wrapping). assert-macros stays detection-only: converting it is judgement-laden (negate the if-guard, match it against the assert text, and not every site is byte-identical), so it is reported, not auto-fixed. After a --fix run such findings are listed as 'left for manual review'. Fixes change only tokens, not layout; run clang-format afterward. tools/check/tests covers the jobj fixer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ribbanya
pushed a commit
that referenced
this pull request
Jun 15, 2026
--fix rewrites source in place to resolve jobj-flags findings locally (--fix --dry-run previews a unified diff): the raw hidden-flag literal is replaced with JOBJ_HIDDEN. The swap is exact — verified to reproduce the #2675 sweep content byte-for-byte across all 73 files (modulo clang-format line wrapping). assert-macros stays detection-only: converting it is judgement-laden (negate the if-guard, match it against the assert text, and not every site is byte-identical), so it is reported, not auto-fixed. After a --fix run such findings are listed as 'left for manual review'. Fixes change only tokens, not layout; run clang-format afterward. tools/check/tests covers the jobj fixer. Co-authored-by: itsgrimetime <990274+itsgrimetime@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2670.