docs: link to RootlessKit docs on master instead of v2.0.0#24954
Open
lacatoire wants to merge 2 commits intodocker:mainfrom
Open
docs: link to RootlessKit docs on master instead of v2.0.0#24954lacatoire wants to merge 2 commits intodocker:mainfrom
lacatoire wants to merge 2 commits intodocker:mainfrom
Conversation
The RootlessKit network and port docs were linked at the v2.0.0 tag, so readers had no way to tell whether the linked content reflects current RootlessKit behavior or a frozen older snapshot. Linking to the master branch (default branch on rootless-containers/rootlesskit, verified) so the references stay current as upstream evolves. Closes docker#24941
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Docker Engine ships RootlessKit v3.0.0 (per moby/moby Dockerfile), and v3.0.0 is also the latest upstream release. Pinning to v3.0.0 keeps the linked content aligned with the binary the reader actually has, while still being current. Avoids the master-branch risk of mentioning post-release features that aren't in the shipped binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RootlessKit network/port docs were linked at the `v2.0.0` tag, leaving readers unsure whether the content reflects current RootlessKit behavior. Switching to the `master` branch (default branch on rootless-containers/rootlesskit, verified that `docs/network.md` and `docs/port.md` exist there) so the references stay current.
Closes #24941