Repository navigation
refactor(rag): make file watching context-owned - #4697
Merged
Merged
Conversation
Stop scheduling new chunk builders once the context is done, but still wait for already-running ones before returning, so no goroutine is left building after buildEmbeddingInputs returns. Assisted-By: docker-agent
aheritier
added
area/rag
aheritier
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
StartFileWatcherwith context-ownedWatchFiles, migrating all callers. File watching now runs in a single joined goroutine per watcher, draining events until the context is cancelled; cancellation is drained and joined before the database is closed. Debounce, overflow, and directory-contents handling are preserved.Includes two prerequisite fixes for the same subsystem: