Repository navigation
refactor(leantui): poll terminal size in the event loop - #4696
Merged
Merged
Conversation
trungutt
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The lean TUI's resize handling relied on a dedicated goroutine, a channel,
and a cached-size variable just to react to terminal resizes. Separately,
PTY race tests surfaced a preexisting shutdown race: canceling input could
race with restoring the terminal, since the reader's
Readwasn't joinedbefore
Close/restore ran.What
fix(leantui): join the canceled input goroutine before restoring theterminal, closing the
cancelreaderRead/Close shutdown race.refactor(leantui): poll terminal size directly in the main event loop(every 250ms) instead of a separate goroutine/channel/cache, updating all
callers accordingly. Removes two goroutines and a channel.
Validation
task build,task test,task lint: clean on this branch (built ontop of current
main).go test ./pkg/leantui/... -race: passing.linux/amd64andwindows/amd64.