Repository navigation
refactor(oauth): scope callback serving to authorization - #4694
Merged
Merged
Conversation
Drop the long-lived CallbackServer type in favor of a single blocking RequestAuthorizationCode call that owns its listener/server/handler for one run, binds before the caller prepares the authorization request, and joins everything on return. Migrates managed, standalone and remote callers. Assisted-By: docker-agent
hamza-jeddad
approved these changes
Oct 21, 2026
aheritier
added
area/mcp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the long-lived
CallbackServer(New/Start/Wait/Shutdown) in favorof a single blocking
RequestAuthorizationCode(ctx, port, prepare)that ownsits listener/server/handler for one run.
credentials/authorization URL, so the redirect target is live earlier
lifetime
rather than racily accepted, fixing a user-observable duplicate-code bug
swallowed
joins on completion
Migrates managed MCP OAuth, standalone OAuth login, and the remote runtime
callers, plus all associated tests/helpers to the new API.
This PR is scoped to the OAuth callback refactor only — no lint or resize
changes included.
Validation
task build,task test,task lintoauthflowtests repeated with-race, 20+ runsGOOS=windowsandGOOS=linuxamd64,CGO_ENABLED=0, for./pkg/tools/mcp/...and./pkg/runtime/...GOOS=js GOARCH=wasmfor./pkg/tools/mcp/oauthflowand./cmd/wasm