Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

[TypeScript] - Enable a TsConfig Ready - #3441

Merged
FrenchBen merged 11 commits into
docker-archive-public:masterfrom
deinok:typescript
Feb 27, 2018
Merged

FrenchBen merged 11 commits into
docker-archive-public:masterfrom
deinok:typescript

Conversation

@deinok

@deinok deinok commented Dec 23, 2017 •

Copy link
Copy Markdown
Contributor

This will allow use the type checkings of typescript.
Detectimng some common errors that JavaScript dont catch

Comment thread package.json Outdated
},
"license": "Apache-2.0",
"electron-version": "0.35.4",
"electron-version": "1.7.10",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that you can still build and launch this on osx/windows? last update to Electron caused some issues for me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is working well, but in not sure if this field is required now

@FrenchBen FrenchBen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - LGTM, but wanted to make sure you could build the proper releases. (sreenshot)

@deinok

deinok commented Dec 28, 2017

Copy link
Copy Markdown
Contributor Author

Seems working well.
TSC command added to all build pipelines of package.json . So any npm command will trigger the build
sin titulo

@FrenchBen

Copy link
Copy Markdown
Contributor

How would this integrate with the current PR to have an actual windows installer generated?
#3447

@FrenchBen
FrenchBen requested a review from jmorganca February 5, 2018 11:28
@deinok

deinok commented Feb 5, 2018 •

Copy link
Copy Markdown
Contributor Author

@FrenchBen This is completely independent of #3447

This will enable us to check errors at compile time (Enabling the ability to use TypeScript and JSX for React).
So any CI will detect build errors without the need of starting any test.

@deinok

deinok commented Feb 27, 2018

Copy link
Copy Markdown
Contributor Author

@FrenchBen Updated to work with Electron-Builder

@FrenchBen

Copy link
Copy Markdown
Contributor

thanks for the rebase!

@FrenchBen
FrenchBen merged commit c666735 into docker-archive-public:master Feb 27, 2018
@deinok
deinok deleted the typescript branch February 27, 2018 20:22
@deinok

deinok commented Feb 27, 2018

Copy link
Copy Markdown
Contributor Author

Perfect, next step is I will port about 1/2 of the code to TypeScript, in order to make the transition more natural.

@FrenchBen

Copy link
Copy Markdown
Contributor

Looks like I keep getting build errors when going through:
Running "shell:linux_npm" (shell) task

Are you able to make a release from ubuntu?

@deinok

deinok commented Mar 10, 2018

Copy link
Copy Markdown
Contributor Author

No, I can't, but it should not be related to this.

Seems some kind of error related only to the grunt targets.

This #3644 should allow anybody to generate the .zip files like when using grunt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants