[TypeScript] - Enable a TsConfig Ready - #3441
Conversation
| }, | ||
| "license": "Apache-2.0", | ||
| "electron-version": "0.35.4", | ||
| "electron-version": "1.7.10", |
There was a problem hiding this comment.
Can you confirm that you can still build and launch this on osx/windows? last update to Electron caused some issues for me.
There was a problem hiding this comment.
Yes, it is working well, but in not sure if this field is required now
FrenchBen
left a comment
There was a problem hiding this comment.
Thanks for the PR - LGTM, but wanted to make sure you could build the proper releases. (sreenshot)
|
How would this integrate with the current PR to have an actual windows installer generated? |
|
@FrenchBen This is completely independent of #3447 This will enable us to check errors at compile time (Enabling the ability to use TypeScript and JSX for React). |
|
@FrenchBen Updated to work with Electron-Builder |
|
thanks for the rebase! |
|
Perfect, next step is I will port about 1/2 of the code to TypeScript, in order to make the transition more natural. |
|
Looks like I keep getting build errors when going through: Are you able to make a release from ubuntu? |
|
No, I can't, but it should not be related to this. Seems some kind of error related only to the grunt targets. This #3644 should allow anybody to generate the .zip files like when using grunt. |

This will allow use the type checkings of typescript.
Detectimng some common errors that JavaScript dont catch