Skip to content

feature Add support for reordering for belongs_to resources - #4

Open
delphist wants to merge 1 commit into
dkniffin:masterfrom
delphist:feature/add-belongs-to-support
Open

feature Add support for reordering for belongs_to resources#4
delphist wants to merge 1 commit into
dkniffin:masterfrom
delphist:feature/add-belongs-to-support

Conversation

@delphist

Copy link
Copy Markdown

#3

@yjukaku

yjukaku commented Jan 17, 2018

Copy link
Copy Markdown

I would love to see this merged. However, I think this might be the better way to go?

reorder_url, query_params = active_admin_resource_for(resource.class).route_instance_path(resource).split '?', 2
reorder_url += "/reorder"
reorder_url += "?" + query_params if query_params
span(reorder_handle_content, :class => 'reorder-handle', 'data-reorder-url' => reorder_url)

@delphist

Copy link
Copy Markdown
Author

@yjukaku need to check it, maybe yes – hard to remember where i'm used it to reproduce the bug. Give me some time, please

@dkniffin

Copy link
Copy Markdown
Owner

@delphist Any update on whether @yjukaku's suggestion works? Also, would you mind fixing the conflict with master?

@dkniffin

Copy link
Copy Markdown
Owner

@delphist is this still valid? If so, can you please rebase to get the new test suite and fix the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants