Closed
Conversation
The state machine for reading uses three states. `Writing`, `Read Length` and `Reading`. Read length will set up the reading state with the expected length and the already read bytes (header). In the reading state, if not enough bytes have been read from the connection, the state machine stays in the reading state. The reading state failed to return the proper state. It reused the `state` var and thus never propagated the updated read var (which is owned in the scope). Everytime, the loop entered the transition from the `Reading` state, `read` was fixed to the initialized value from the `Reading Length` state. This caused the connection to be stuck for large responses (for example a `<check>` with over 20 domains). We now emit a new `Reading` state with updated values.
Contributor
Author
|
Nevermind, just saw #84. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state machine for reading uses three states.
Writing,Read LengthandReading.Read length will set up the reading state with the expected length and the already read bytes (header).
In the reading state, if not enough bytes have been read from the connection, the state machine stays in the reading state.
The reading state failed to return the proper state. It reused the
statevar and thus never propagated the updated read var (which is owned in the scope). Everytime, the loop entered the transition from theReadingstate,readwas fixed to the initialized value from theReading Lengthstate. This caused the connection to be stuck for large responses (for example a<check>with over 20 domains).We now emit a new
Readingstate with updated values.