Develop - #40
Merged
Merged
Conversation
…remove auto-merge from homebrew tap PR job Signed-off-by: Division 7 <divisionseven@users.noreply.github.com>
The smoke-test job was removed from release.yml but the test validating required pipeline jobs still expected it. Removed "smoke-test" from the expected_jobs list. All 4504 tests pass. Signed-off-by: Division 7 <divisionseven@users.noreply.github.com>
divisionseven
added
the
area: ci-cd
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned Files
|
pascalthedev
approved these changes
Jul 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the release pipeline smoke-test job and the Homebrew tap auto-merge step from
.github/workflows/release.yml.The smoke-test job was a persistent source of release-blocking failures, first a pip
--hashsyntax regression, then intermittent PyPI propagation timeouts. Its verification was already covered by existing pipeline gates (binary version checks inbuild-binaries, formula validation inupdate-homebrew-tap), so it added zero unique coverage while blocking every release that hit it.The auto-merge step on the Homebrew tap PR bypassed manual review of structural formula changes (license, platform blocks,
desc). The PR is still created automatically, only the merge is now gated behind human review.Type of Change
Motivation and Context
Smoke-test job: Three consecutive release attempts failed at this step, once on a pip syntax regression (
--hashnot valid as CLI flag), then on PyPI propagation timeout. Each failure required a full re-run of the release pipeline (validate → CI → build → docker → binaries → provenance → release → publish → smoke-test), wasting ~30 minutes of CI time. The job's checks (version match, CLI smoke test, binary download) duplicated coverage frombuild-binariesbinary verification and Homebrew tapbrew test.Auto-merge: The
peter-evans/enable-pull-request-automergestep merged Homebrew tap PRs without human review. Manual review is preferred to catch structural formula changes (license updates, platform block additions,descchanges) that automated validation might miss.Implementation Notes
Removed:
smoke-testjob block (~91 lines): 10 steps including venv creation, PyPI polling, CLI verification, binary download/verify, cleanupEnable auto-mergestep (~8 lines): thepeter-evans/enable-pull-request-automergeaction withmerge-method: squash─► smoke-testreference in the ASCII pipeline diagram comment (line 10)Testing
pytest --cov-fail-under=90)pytest tests/integration/test_smoke_e2e.py --tb=short -q)Checklist
ruff check .andruff format --check .)mypy .)pytest --cov-fail-under=90)docs/reference/exit-codes.mdCHANGELOG.mdwith a brief entry under[Unreleased]pyproject.tomlRelated Issues / PRs
None.