fix(security): resolve OSSF Scorecard vulnerabilities findings - #27
Merged
Conversation
Signed-off-by: Division 7 <divisionseven@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
pascalthedev
requested review from
pascalthedev
and removed request for
Pork0594
July 20, 2026 01:44
pascalthedev
approved these changes
Jul 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the OpenSSF Scorecard Vulnerabilities check on
main. Resolves all 27 findings across three root causes:osv-scanner.toml)idna3.11 → 3.18, PYSEC-2026-215)npm audit fix)Type of Change
Motivation and Context
After merging the security certification branch (
feat/security-certification), the Scorecard Vulnerabilities check dropped to 0/10 because Scorecard found 27 OSV-reported vulnerabilities. The scoring formula ismax(0, 10 - numVulnsFound), so 27 findings = 0.Root causes identified via source-level investigation of Scorecard (
ossf/scorecard) and OSV-Scanner (google/osv-scanner) Go source code:Test fixture lock files (20 findings):
tests/fixtures/lock_files/contains 8 lock files with deliberately old versions for parser testing. OSV-Scanner scans them as real dependencies. OSV-Scanner v2.3.2 supports per-directoryosv-scanner.tomlconfig with[[PackageOverrides]] ignore = truethat suppresses findings before any API call.Transitive idna dependency (1 finding, PYSEC-2026-215):
idna==3.11resolved viaaiohttp → yarl.yarldeclaresidnawith no version constraint, so uv picked the minimum compatible = 3.11. Addingidna>=3.15as a direct constraint forces resolution to a non-vulnerable version.GHA dev dependencies (2 findings):
@babel/core@7.29.0(GHSA-4x5r-pxfx-6jf8) andjs-yaml@3.14.2(GHSA-h67p-54hq-rp68) are transitive dev deps ofjest. Both fix within existing^semver ranges.Implementation Notes
manager.go:74-84), the filter pipeline (filter.go:82-107), and the Scorecard scoring formula (vulnerabilities.go:38-47).osv-scanner.tomluses emptyPackageOverrides(no name/ecosystem filters) which matches all packages in that directory tree — verified from thematches()function inconfig.go:107-131.npm audit fixonly modified the lockfile within existing^semver ranges; both upgraded packages are dev-only and don't appear in the productiondist/index.jsbundle.Testing
pytest --cov-fail-under=90)Manual testing performed: Each fix mechanism verified independently — TOML syntax validated,
uv.lockconfirmed idna3.18,package-lock.jsonconfirmed@babel/core 7.29.7andjs-yaml 3.15.0.Checklist
ruff check .andruff format --check .)mypy .)pytest --cov-fail-under=90→ 91.26%)CHANGELOG.mdwith entries under[Unreleased]pyproject.toml—idna>=3.15addedRelated Issues / PRs
Follow-up to: PR #23 #24 (
feat/security-certification)