Add support for defining RDS parameter groups#6864
Open
Conversation
93f5e66 to
2c5e387
Compare
The docstring represents my understanding based on commit history.
Consistency in the map names, but easy to distinguish which is which (hopefully).
2c5e387 to
227b392
Compare
millerdev
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/SAAS-19633
When upgrading postgres via terraform, terraform wants to delete the attached parameter group since it is only referenced by the rds instance, and once upgraded, a new group will be created/attached targeting that new version of postgres.
Ideally, we would first create the new parameter group targeting the new version of postgres, which will then allow us to easily compare the existing parameter group and the new group in the AWS console to see what has changed/new defaults, etc. Once confident, we can then update the engine version and parameter_group at the same time, resulting in a successful upgrade.
This supports both the existing way of defining parameter "in-line" in the rds instance or defining them in a separate parameter group and linking that group to the instance. If both are defined on an instance, an error is raised.
Example usage
Environments Affected
None