Conversation
digint
left a comment
There was a problem hiding this comment.
thanks for contributing!
(sorry for the long delay, i missed that one)
can we move this to contrib/cmake (or similar)
I'd hate to pollute this "tiny ;-) header-only" project with configs from all sort of build systems and IDE's (see #28 )
|
|
||
| project("tinyfsm" | ||
| LANGUAGES CXX | ||
| VERSION 1.0.1 |
There was a problem hiding this comment.
why 1.0.1 ? should be 0.3.2
Can we extract this from include/tinyfsm.hpp line 26 ?
If not, do you know of some common / portable place to define the version number?
I'd hate to maintain the version in multiple files.
the "library" (API compatibility) version would be 0.3
| cd build | ||
| cmake .. | ||
| sudo cmake --build . --target install | ||
| ``` |
There was a problem hiding this comment.
cmake users should all know how this works, do you really think this is required? maybe add instructions in header of CMakeLists.txt
This makes it a bit simpler to include in projects using Cmake. I've tested installation and project builds on macOS and Ubuntu 18.04.