Skip to content

fix: improve API parameter parsing in Bridge#249

Open
MatrixNeoKozak wants to merge 1 commit into
didi:mainfrom
MatrixNeoKozak:fix/improvement-1781520447366
Open

fix: improve API parameter parsing in Bridge#249
MatrixNeoKozak wants to merge 1 commit into
didi:mainfrom
MatrixNeoKozak:fix/improvement-1781520447366

Conversation

@MatrixNeoKozak

Copy link
Copy Markdown

Corrected the parsing logic for API parameters in Bridge.handleApiInvocation. Previously, JSON strings passed as parameters were treated as raw strings, failing API calls that expected structured JSONObject or JSONArray parameters. Updated to attempt parsing string parameters into structured JSON before invoking the API.

@dos1in

dos1in commented Jun 15, 2026

Copy link
Copy Markdown
Member

Thank you for your pr, the new global parsing treats any string shaped like {...} or [...] as structured JSON instead of preserving it under args. Existing APIs intentionally pass bare strings through this bridge: canIUse(schema), FileSystemManager.accessSync(path), readdirSync(dirPath), unlinkSync(filePath), etc., and Android handlers read those from args. A valid string value like a JSON-looking filename/path or schema would now arrive without args and fail as “missing file path” or false. Keep direct string params as args, and only parse JSON strings in a narrower API-specific path if that contract really requires it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants