fix: improve API parameter parsing in Bridge#249
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
Member
|
Thank you for your pr, the new global parsing treats any string shaped like {...} or [...] as structured JSON instead of preserving it under args. Existing APIs intentionally pass bare strings through this bridge: canIUse(schema), FileSystemManager.accessSync(path), readdirSync(dirPath), unlinkSync(filePath), etc., and Android handlers read those from args. A valid string value like a JSON-looking filename/path or schema would now arrive without args and fail as “missing file path” or false. Keep direct string params as args, and only parse JSON strings in a narrower API-specific path if that contract really requires it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the parsing logic for API parameters in Bridge.handleApiInvocation. Previously, JSON strings passed as parameters were treated as raw strings, failing API calls that expected structured JSONObject or JSONArray parameters. Updated to attempt parsing string parameters into structured JSON before invoking the API.