Skip to content

Conversation

@andrewbattat
Copy link
Contributor

@andrewbattat andrewbattat commented Dec 26, 2025

@andrewbattat andrewbattat self-assigned this Dec 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).

Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:

Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.

To acknowledge this reminder and unblock the PR, dismiss this code review by:

  • Going to the bottom of the pull request page
  • Finding where this bot is requesting changes
  • Clicking the three dots on the right
  • Selecting "Dismiss review"

For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.

CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP

@andrewbattat
Copy link
Contributor Author

andrewbattat commented Dec 29, 2025

I want to follow up on this with another reorganization, but this is enough for now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of duplication in the metrics folder accross fstrim_tool, metrics_tool, and nft_exporter (and hostos_tool/src/prometheus_metric.rs). Created ticket to consolidate: https://dfinity.atlassian.net/browse/NODE-1815

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankdavid I didn’t touch any of the SEV logic, but we have separate folders for “attestation” “remote_attestation”, “sev” and “guest_upgrade” (which is specific for SEV GuestOS upgrades), and I assume this can be better consolidated. At the very least, they can all be put under a top-level “tee” folder.

@andrewbattat andrewbattat marked this pull request as ready for review December 31, 2025 00:07
@andrewbattat andrewbattat requested review from a team as code owners December 31, 2025 00:07
@github-actions github-actions bot added the @node label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant