-
Notifications
You must be signed in to change notification settings - Fork 372
refactor(node): reorganize rs/ic_os #8194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).
Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:
Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.
To acknowledge this reminder and unblock the PR, dismiss this code review by:
- Going to the bottom of the pull request page
- Finding where this bot is requesting changes
- Clicking the three dots on the right
- Selecting "Dismiss review"
For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.
CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP
|
I want to follow up on this with another reorganization, but this is enough for now! |
Strictly a refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of duplication in the metrics folder accross fstrim_tool, metrics_tool, and nft_exporter (and hostos_tool/src/prometheus_metric.rs). Created ticket to consolidate: https://dfinity.atlassian.net/browse/NODE-1815
This reverts commit 9805588.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankdavid I didn’t touch any of the SEV logic, but we have separate folders for “attestation” “remote_attestation”, “sev” and “guest_upgrade” (which is specific for SEV GuestOS upgrades), and I assume this can be better consolidated. At the very least, they can all be put under a top-level “tee” folder.
NODE-1738