feat(windows): integrate beta.9 desktop runtime - #44
Draft
devswha wants to merge 23 commits into
Draft
Conversation
Merge origin/main while preserving Windows Job Object ownership and NSIS packaging alongside Linux and macOS desktop behavior. Refresh the Windows SDK 0.16.4 native closure, handle transient Bun executable locks, and include real SDK resource-lifecycle contracts in Windows verification.
Restore byte-stream readiness parsing and Unix graceful shutdown semantics. Keep Unix forced startup cleanup on owned handles and Windows failed-reap recovery observing the existing Job before allowing a retry. Retain forced-cleanup and failed-kill regression coverage, format the native core using its declared edition, and finalize closed Bun SQLite statements before removing Windows SDK test fixtures.
Owner
Author
|
Implementation is paused at the owner's request; the SDK source/dependency scope expansion was not approved. The durable Windows handoff is committed and pushed in 044fe8d: docs/V2-SESSION-HANDOFF.md. It records the 3a9506f source/test state, isolated native SDK failure, exact CI evidence, safety constraints and remaining installer/interactive acceptance. This PR remains draft and release-blocked. Further implementation requires a new owner instruction; no SDK patch, dependency change, gate bypass or release was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdkHostModeSupported: false, runtime-only delegated model roles, strictflushOrThrow(), exact construction-failure ownership, and cleanup poisoning.Blocking SDK finding
At 11bee00, Windows run 34056951959 reproduced the failure without creating any AgentSession. On Windows build 10.0.20348,
snapshotDirectoryTreesucceeds but public nativeexactRemoveDirectoryTreereturns{ok:false,code:"sharing_violation",detachedPath:<original lock path>}. Native removal, SDK release and concurrent SDK release all fail on both C: temporary and D: checkout paths. The same six cases pass on local Windows 11 build 10.0.26200. The handle holder is not established; no antivirus attribution is made.This isolates the pinned SDK/native filesystem release path, not an app broker or SessionManager. Both packages' latest published version is still 0.16.4. The dependency-change prohibition remains in effect; no SDK workaround has been applied.
Commit-scoped verification
dist-native/gajae-core.exe.Acceptance boundary
Draft PR, not a release; no main-branch merge is authorized. Current Windows runtime is blocked by the pinned native SDK failure. Installer construction and silent installed-backend smoke do not establish interactive GUI/login, a real paid-provider turn, deep-link, reinstall/uninstall or signing acceptance. Historical beta.8 evidence remains separately scoped in docs/WINDOWS-DESKTOP.md.