Open
Conversation
arosov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I use this code to list desktop sources https://jrtc.dev/guide/video/desktop-capture#desktop-video-source-selection
It works on 0.10.0.
Crashes on 0.11.0 and superior (also on main).
From what i understood investigating:
For some reason way too low level for me, having this kind of mix could be dangerous for ABI stability.
Due to that mismatch, the jenv pointer could get corrupted. It turns out this is not my issue, it came up while investigating. Not sure if it's relevant or LLM rambling.
I then figured out that WEBRTC_USE_X11 missing was my issue (+ Xlibs). Tested on v0.14.0 and main with that single commit.
Also tested the set of 3 commits on v0.14.0 and main.