Repository navigation
Add a CI passed gate for branch rules and leave one expected failure - #5
Merged
Merged
Conversation
The unnamed job no longer fails a step: with a token the API refuses, the action uploads whether or not a step failed, so the job can pass. Failed test step must fail for real, since continue-on-error on the step makes the API report it as a success, so it is renamed to say the failure is expected. The gate needs every other job and is the one check branch rules require.
Mira PR WalkthroughAdds a Confidence: 4/5 ◉◉◉◉○ Safe with minor follow-up
1 file reviewed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one check for branch rules to require, and cuts the jobs that fail on purpose from two to one.
gate) needs every job except the expected failure. It runs withalways(), because GitHub counts a skipped required check as passed. It fails if any job it needs failed, was cancelled or was skipped, and lists which ones.continue-on-erroron the step, the jobs API reports the step assuccess(seen on "Failed start on ubuntu-latest"), and the action correctly uploads nothing. A run dispatched from CI wouldn't help either, since its checks attach to the same commit. The artifacts job needs this job and checks its logs, which is why the gate leaves it out.After merging, require only
CI passedin the branch rules.#4 adds a
lockfilejob. Whichever of the two PRs merges second should addlockfileto the gate'sneeds. Theunnamedchange appears in both PRs and is identical, so it merges cleanly.