Conversation
fincs
left a comment
There was a problem hiding this comment.
1/N review done, definitely will be more
|
Thank you for the review. Sorry about the typos. Just copying these down so they don't get buried. |
b50ed0e to
8c291c5
Compare
c208264 to
1bf702c
Compare
|
This PR looks great! It may have gotten a little stale but would still be valuable to have. Any chance of it being revived and/or accepted + published? I have been using https://oreo639.github.io/citro3d/index.html as my go-to for citro3d docs and would love to see this upstreamed and officially published. If it would be helpful, I can try to review or help any other way, but I am of the opinion that any amount of docs is better than none! Let me know if there's any way to help see this PR through across the finish line. |
|
Thanks for the comments. Here is a brief overview of what needs to be finished:
These are things I would preferably experiment with and write applications using them and I just haven't gotten around to that yet. Here is a list of other remaining tasks in order from most to least important:
I'm sorry about the delay, my attention has primarily been focused on other projects, but I'll try to look into this more in two weeks give or take. |
90ad127 to
49de608
Compare
ian-h-chamberlain
left a comment
There was a problem hiding this comment.
@oreo639 thanks for updating! I have not been using the library for long so I'm not sure how much review help I could provide, but I left some comments/questions for things I saw in the PR.
Depending how the maintainers feel, I think it could be valuable to merge the PR even as-is and allow for future documentation improvements to come in separately, but maybe they'd rather have everything all at once?
| * @param[in] color Specifies the RGBA blend color. The initial value is 0. | ||
| */ | ||
| void C3D_BlendingColor(u32 color); | ||
|
|
There was a problem hiding this comment.
missing doc for C3D_EarlyDepthTest ?
| void C3D_ColorLogicOp(GPU_LOGICOP op); | ||
|
|
||
| void C3D_FragOpMode(GPU_FRAGOPMODE mode); | ||
|
|
There was a problem hiding this comment.
couple of other missing docs here as well, it looks like, but these functions also seem to be pretty self-explanatory so it may not be worth adding.
03719df to
e017b56
Compare
4531901 to
ba70b26
Compare
ian-h-chamberlain
left a comment
There was a problem hiding this comment.
I'm not really enough of a domain expert to review all the descriptions, but I'd love to see this accepted in some form! Thanks for your efforts @oreo639 — this looks like a huge undertaking and having citro3d documentation like this would be super valuable!
|
Does anyone know anything about fog/gas rendering? The wiki's empty of description with just the source code shown |
|
There is already a fog example. As for gas support, the current code in citro3d is unfinished. I intend to revisit this soon. |
8d363fe to
071946f
Compare
fde4c32 to
bc3d68e
Compare
Fragment lighting equations based on https://mathb.in/26766 from Halcy.
This is a work in progress pr to finish the documentation for citro3d.
You can check out the pr's docs here:
https://oreo639.github.io/citro3d/index.html
Warning:
This may contain mistakes or poor wording choices.
Comments are welcome.
Note: The PR should be mostly complete, however the last commit will need to be changed when merged.