feat: hide CIRA in profile when disabled on the server - #3514
Open
nmgaston wants to merge 1 commit into
Open
Conversation
4 tasks
nmgaston
changed the title
nmgaston
force-pushed
the
fix-cira-warning-clean
branch
from
August 21, 2026 20:39
eb1beb5 to
9b00455
Compare
madhavilosetty-intel
force-pushed
the
fix-cira-warning-clean
branch
2 times, most recently
from
August 26, 2026 22:39
831b639 to
ad76cfb
Compare
Hide the CIRA connection mode once the Console server reports CIRA disabled, but keep it visible and disabled while /server/features is still in flight, so a saved CIRA profile does not render an empty radio group during the call. Warn on save only when saving actually drops a stored CIRA config, i.e. editing a profile created with one on a server where CIRA is now disabled. It previously fired on every non-CIRA save, which blocked submit in the unit specs and the Cypress profile suites. A stored non-TLS profile comes back with tlsMode 0, which Validators.required accepts while the select renders blank, so the coerced profile saved silently with TLS off. Blank an out-of-range tlsMode when TLS is selected and surface the required error.
madhavilosetty-intel
force-pushed
the
fix-cira-warning-clean
branch
from
August 26, 2026 22:59
ad76cfb to
ffb99a8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Profiles UI to better handle cases where CIRA is disabled on the server (enterprise flavor), preventing users from selecting or editing CIRA settings when unavailable and introducing a dedicated confirmation dialog when saving would drop an existing CIRA configuration.
Changes:
- Added a “No CIRA” warning dialog and corresponding i18n strings.
- Updated
ProfileDetailComponentto track when CIRA availability is resolved, hide/disable CIRA UI appropriately, and coerce existing CIRA profiles to TLS when CIRA is confirmed disabled. - Expanded unit tests to cover the new availability-resolved behavior, UI visibility, coercion, and save-confirmation flow.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/assets/i18n/ar.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/de.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/en.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/es.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/fi.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/fr.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/he.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/it.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/ja.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/nl.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/ru.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/assets/i18n/sv.json | Adds noCira.* dialog strings; removes profileDetail.ciraDisabledOption. |
| src/app/shared/no-cira-warning/no-cira-warning.component.ts | Introduces the new dialog component (standalone-style imports). |
| src/app/shared/no-cira-warning/no-cira-warning.component.html | Dialog UI/wording layout for the “CIRA config will be removed” warning. |
| src/app/shared/no-cira-warning/no-cira-warning.component.scss | Styling for the new dialog. |
| src/app/shared/no-cira-warning/no-cira-warning.component.spec.ts | Basic unit test coverage for the new dialog component. |
| src/app/profiles/profile-detail/profile-detail.component.ts | Adds resolved-availability signal, coercion logic, sequential dialog flow, and “drop CIRA config” warning gate. |
| src/app/profiles/profile-detail/profile-detail.component.html | Conditionally shows/hides CIRA option based on resolved availability; adjusts TLS error display. |
| src/app/profiles/profile-detail/profile-detail.component.spec.ts | Adds tests for resolved/pending CIRA availability behavior and new warning flow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "value": "Dit profiel heeft een bestaande CIRA-configuratie, maar CIRA is momenteel uitgeschakeld op de server. Het opslaan van dit profiel verwijdert de CIRA-configuratie." | ||
| }, | ||
| "noCira.title": { | ||
| "description": "Titel van het dialoogvenster voor de CIRA-verwijderingswarschuwing", |
Comment on lines
+193
to
+195
| component.ciraEnabled.set(false) | ||
| ;(component as any).ciraAvailabilityResolved.set(true) | ||
|
|
Comment on lines
+203
to
+205
| component.ciraEnabled.set(false) | ||
| ;(component as any).ciraAvailabilityResolved.set(false) | ||
|
|
Comment on lines
45
to
+47
| import { RandomPassAlertComponent } from '../../shared/random-pass-alert/random-pass-alert.component' | ||
| import { StaticCIRAWarningComponent } from '../../shared/static-cira-warning/static-cira-warning.component' | ||
| import { NoCIRAWarningComponent } from '../../shared/no-cira-warning/no-cira-warning.component' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #3445
This pull request refines the handling of the CIRA (Cloud Internet Remote Access) feature in the profile management UI, improving both the user experience and code maintainability. The main changes ensure that CIRA options only appear when available, prevent users from selecting CIRA when it's disabled, and clean up related UI and translation strings. The test suite is expanded to cover these scenarios.
CIRA feature handling and UI improvements:
profile-detail.component.htmlare now only shown if CIRA is enabled, preventing users from selecting or viewing CIRA options when the feature is unavailable. The fallback logic ensures profiles referencing CIRA automatically switch to a supported mode if CIRA is disabled.Logic and state management:
Introduced a new
ciraAvailabilityResolvedsignal to track when the server's CIRA feature status is known, preventing premature changes to profile forms before the server response arrives.Test coverage:
Added and updated tests in
profile-detail.component.spec.tsto verify correct behavior when CIRA is enabled, disabled, or the feature status is pending, including automatic fallback logic and UI visibility.Translation cleanup:
Removed unused translation strings related to CIRA being disabled from all localization files, as the warning and inline notes are no longer shown in the UI.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )