feat(activation): prevent orphaned MPS device records on re-provision

[rsdmike]

Add the opt-in prevent_orphaned_devices config flag (default off). When enabled, a device reporting pre-provisioning mode (currentMode=0) that still has a record in the MPS devices table is refused until it is removed via rpc-go deactivation or the REST API, keeping the devices table free of orphaned/duplicate records. Disabled by default, so existing behavior is unchanged. Fails open if MPS is unreachable or the device is not registered.

PR Checklist

• Unit Tests have been added for new changes
• API tests have been updated if applicable
• All commented code has been removed
• If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

[Copilot]

Pull request overview

Adds an opt-in activation safety check (prevent_orphaned_devices, default false) to reduce duplicate/orphaned device records in MPS by refusing to re-provision devices that report pre-provisioning mode (currentMode=0) while still being present in MPS.

Changes:

• Add prevent_orphaned_devices config flag (default off) and plumb it through RPSConfig + environment defaults.
• During activation validation, optionally query MPS for an existing device record when currentMode=0 and block re-provisioning if present.
• Add unit tests for the new opt-in behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Validator.ts	Adds the prevent_orphaned_devices gated MPS existence check during currentMode=0 activation validation.
src/validator.test.ts	Adds tests covering default-off behavior, “no record”, “record exists”, and “fails open” paths.
src/utils/Environment.ts	Sets default value for prevent_orphaned_devices in the environment config singleton.
src/models/index.ts	Extends RPSConfig with the optional prevent_orphaned_devices field.
.rpsrc	Documents the new config flag in the default rc config.

Suppressed comments (1)

src/validator.test.ts:578

• This test doesn’t assert that the MPS lookup was actually attempted, so it could still pass if the lookup is removed. Add an assertion on got calls (and clear mock call history) to ensure the “fails open” path is exercised.

      Environment.Config.prevent_orphaned_devices = true
      devices[clientId] = { ClientId: clientId, ClientSocket: null as any, unauthCount: 0, status: {} } as any
      vi.mocked(got).mockRejectedValue(new Error('Response code 404'))
      await validator.verifyCurrentModeForActivation(msg, profile, clientId)
      expect(devices[clientId].status.Status).toBeUndefined()

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[RosieAMT]

🎉 This PR is included in version 2.40.0 🎉

The release is available on:

• GitHub release
• v2.40.0

Your semantic-release bot 📦🚀