feat: Expose proxy and custom-CA client options - #724
Merged
kylebarron merged 7 commits intoJun 25, 2026
Conversation
kylebarron
reviewed
Jun 16, 2026
kylebarron
left a comment
kylebarron
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! This is a good start
Comment on lines
+9
to
+28
| CERT_1 = b"""-----BEGIN CERTIFICATE----- | ||
| MIIDGzCCAgOgAwIBAgIUBqLgQSw4wiW06IhiKHNN5NyztG8wDQYJKoZIhvcNAQEL | ||
| BQAwHDEaMBgGA1UEAwwRb2JzdG9yZS10ZXN0LWNhLTEwIBcNMjYwNjE2MTQxMjEz | ||
| WhgPMjEyNjA1MjMxNDEyMTNaMBwxGjAYBgNVBAMMEW9ic3RvcmUtdGVzdC1jYS0x | ||
| MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxw/NGsR0jwDKOSyXsfeT | ||
| WvniRh+bozmvQuyxW/qZwuNrgrkPdZbSM3j3eaqFOa9iqSds17u3bTYnC08SGyjo | ||
| hecOuja2KP5lYUJ31Vfad4KlkYVuNBjQ3FZb71jbwXuwKnhcrYlMUM8Vt/Oay/q+ | ||
| uKDG0kMXTdjXButCFE+s8oTk0dlGEjQ6IuI3/0l5cv631iMIaIW13CDG1mMJwu9Q | ||
| yco8/J6aK6ZQFa0T9TRm2v3Y/3qiX+WryQakX72IY9DbRtxwjh0Lm81M46DChsE3 | ||
| FyZB69aaKPdSkWUmNAWBa3H8cQziUv2SLz6DAG7r5cJZ0xkbqgiaQR8P1ud8yeL+ | ||
| LwIDAQABo1MwUTAdBgNVHQ4EFgQUJGhd1ORfcw1Ov3/fljWfEoUJSx8wHwYDVR0j | ||
| BBgwFoAUJGhd1ORfcw1Ov3/fljWfEoUJSx8wDwYDVR0TAQH/BAUwAwEB/zANBgkq | ||
| hkiG9w0BAQsFAAOCAQEAurAH4Gvomh4QffpZf6s3/TPXHGM2wuuuOKB7QD7sfp8V | ||
| nlFthbcpEd0SRaH2T4fIeVDuHcMx/F7GYBaVOjXqRq9N6+zeutpPvu7YAoE4zbLz | ||
| Wnrn2fZG5uAO+HW26QXOsZU2zJHpHzZWZ3G1dV/C97k8hmSjkH7OOZSlZ/qIN4+p | ||
| 5t5qBUJek66luxnEyfOdFitiJe9Ri6sj2ffT0aXejZCu2boO+3Szm6boLu3kCC7l | ||
| Latj8uDxEm6HsD4gxn61zMmmSjitTJYJt+lW8+3tlSf17tXd1TLG/cF/0gD28OhL | ||
| UmOHI1HSNtVKwotBkpOrlby1hWOX7IMtqPRmEJzz6Q== | ||
| -----END CERTIFICATE----- | ||
| """ |
Member
There was a problem hiding this comment.
Just for my knowledge, how were these test cases defined? Is this random input?
Contributor
Author
There was a problem hiding this comment.
I generated them using openssl, I've added the command as a comment now
openssl req -x509 -newkey rsa:2048 -nodes -days 36500 -subj /CN=obstore-test-ca-N
Member
There was a problem hiding this comment.
Cool, thanks. I've never touched custom certificates myself
kylebarron
reviewed
Jun 18, 2026
kylebarron
left a comment
kylebarron
left a comment
Member
There was a problem hiding this comment.
Thanks! Just a few more comments
Comment on lines
+16
to
+17
| /// The original PEM is retained so the value round-trips through | ||
| /// [`IntoPyObject`]; parsing happens once, on extraction. |
Member
There was a problem hiding this comment.
👍 I see, it looks like there's no method on Certificate to go back to a PEM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
My use case is that there's an internal corp proxy which has a custom certificate which then connects to an s3 compatible API service.