BACKUP ToOs - #889
Conversation
|
Thank you are the review and the catch! I forgot to rerun
since the BACKUP ToO is technically not a secondary? This is more of a bookkeeping issue so please let me know if I should change it to |
|
Oh, yes, excellent point. That should indeed be changed to
We might want to check with @dylanagreen (if you didn't already) as to whether |
|
On further review, I don't think this approach will work for I think perhaps the cleanest solution, then, is to instead put these new bits directly in the |
|
Thanks for looking at it again! I will give that a try locally and report back! |
|
I made the changes and it looks like it worked! I reran |
geordie666
left a comment
There was a problem hiding this comment.
A few more comments to address before we can merge this.
In addition, please update the doc/changes.rst file to describe this PR.
|
@jbanovetz: I think this is ready to merge from the One question, though, will complementary changes to |
I have made changes to
desitargetso that if there are nearby and bright ToOs, these ToOs can be ingested and we can get the ToO spectra.The changes I made are to include the BACKUP program in the
ToO.pyfile and to add the BACKUP ToOs to thetargetmask.yamlunder thebgs_mask.I ran this through
fba_launchand was able to successfully assign the BACKUP ToOs to a tile. The command I used wasAnd the
TOODIRused was:/global/cfs/cdirs/desi/users/banovetz/ToO_desitarget_test