Repository navigation
docs/fix/test: NFS cleanup docs, telemetry Pulp OS version, and RFC 5737 test addresses - #5816
Merged
Merged
Conversation
…es and tests The PR policy blocks 100.x.x.x IPv4 addresses in newly added lines. Three example and test addresses in the telemetry tests used that range: test_config.yml (idrac_nft_bmc_ip example) and test_idrac_bmc_inventory.py (BMC IPs used as test keys). Replace them with 192.0.2.0/24 documentation addresses (RFC 5737). The test logic is unchanged: the addresses are only keys, and the function under test does not check address ranges. Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
The telemetry role derived pulp_os_version from the first orchestrator inventory group whose name contains a RHEL version. In hybrid clusters that group can belong to another domain (for example a login or slurm node on RHEL 10.0), so the version resolved to 10.0 while the telemetry packages are synced for 10.2. Strimzi and Victoria Metrics downloads then failed with HTTP 404. Telemetry runs only on the service K8s cluster, so consider only service_kube_* groups when deriving the version. Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
…NFS server data The cleanup README described server-side NFS deletion as a setting users could enable, and said it was controlled by cleanup_nfs_server. That flag is internal and fixed to false, and the runtime banners already report that NFS share data was not automatically cleaned up and must be removed manually. Align the README with that behaviour: cleanup unmounts the component storage and removes its fstab entries, and NFS server data is removed manually. Remove the instructions for enabling server-side deletion and the descriptions of its behaviour, and drop the "By default" wording that implied a setting. Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
mithileshreddy04
marked this pull request as ready for review
November 16, 2026 12:14
mithileshreddy04
requested review from
RvishankarOMnia,
VenkateswaraVatam,
abhishek-sa1,
priti-parate,
snarthan and
sujit-jadhav
as code owners
November 16, 2026 12:14
priti-parate
approved these changes
Nov 16, 2026
abhishek-sa1
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Solution
This PR bundles three small changes:
cleanup_nfs_serveris fixed tofalse), and the runtime banners already say the data must be removed manually. The README now matches that.pulp_os_versionfrom the first inventory group containing a RHEL version. In hybrid clusters that group can belong to another domain, so Strimzi and Victoria downloads requested the wrong/rhel/<version>/path and failed with HTTP 404. The derivation now considers onlyservice_kube_*groups.192.0.2.0/24).Related Issue
Changes
Orchestrator cleanup docs (
src/orchestrator/playbooks/cleanup/README.md)Telemetry role (
src/telemetry/roles/common/tasks/load_telemetry_config.yml)pulp_os_versiononly fromservice_kube_*inventory groups.Telemetry tests (
test/telemetry/test_config.yml,test/telemetry/ut/test_idrac_bmc_inventory.py)100.10.x.xexample and test addresses with192.0.2.xdocumentation addresses. The test uses them only as keys.Files Changed
src/orchestrator/playbooks/cleanup/README.mdsrc/telemetry/roles/common/tasks/load_telemetry_config.ymlservice_kube_*groups.test/telemetry/test_config.yml192.0.2.61.test/telemetry/ut/test_idrac_bmc_inventory.py192.0.2.120and192.0.2.121.Testing
pytest ut/test_idrac_bmc_inventory.py -vfromtest/telemetry.ansible-playbooksyntax check and a telemetry deploy against a hybrid inventory where a non-K8s group uses a lower RHEL version. Confirm the Strimzi download requests/rhel/10.2/.Backward Compatibility
service_kube_*group are unaffected. If no such group exists, the existing fail task still reports the error.