Repository navigation
test(orchestrator): redirect IPoIB validation logs to report_path and remove them after each case - #5802
Merged
Conversation
Telemetry cleanup skipped every removal when kube_vip could not be
resolved, leaving the validator log and generated output files behind.
cleanup --all then aborted in its preflight on
validate_telemetry_input.log under telemetry/log.
Move the log, output, and stray iDRAC report removal outside the
kube_vip gate. These are local files with no cluster dependency.
Keep input removal inside the gate so staged configuration is not
deleted while sink volumes may still remain in the cluster. The input
directory is already allowed by the cleanup preflight.
Revert the preflight exclusion for validate_telemetry_input.log added
in the previous commit, since the log is now removed by cleanup.
Output removal deletes telemetry_status.yml when Delete_sinks_volume is
set. output-contract.md still says this file is preserved and needs an
update to match.
Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
mithileshreddy04
marked this pull request as ready for review
November 13, 2026 08:55
mithileshreddy04
requested review from
RvishankarOMnia,
VenkateswaraVatam,
abhishek-sa1,
snarthan and
sujit-jadhav
as code owners
November 13, 2026 08:55
…ter each case The IPoIB input FVT validates each case against a scratch project named omnia_fvt_ipoib_<hex>. The validator wrote its log to <OMNIA_DATA_PATH>/orchestrator/log/<scratch>/, and the teardown removed only the scratch input and output directories, so every run left a log directory behind that blocked omnia cleanup --all. The validate_orchestrator_input role now takes an optional orchestrator_validation_log_dir variable for the validator's log directory. When it is not set, the default path is used, so deploy, precheck, and validate runs are unchanged. The FVT passes its scratch log directory under report_path (<report_path>/ipoib_inputs/logs/<scratch>) through that variable. The teardown removes that directory with the scratch input and output. The test does not read the log, so removing it does not change any result. Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
mithileshreddy04
force-pushed
the
staging
branch
from
November 13, 2026 09:16
8a512ea to
bf4410b
Compare
…e project log The IPoIB input FVT validates each case against a scratch project named omnia_fvt_ipoib_<hex>. The validator writes its log under orchestrator/log/<scratch>/, and teardown removed only the scratch input and output, so every case left a new log directory behind that blocked omnia cleanup --all. After each validation, copy that scratch log into the active project's single validation log, orchestrator/log/<project>/orchestrator_validation_<project>.log. The first case of a run rewrites the file and later cases append to it, each with a header naming its scratch project. Teardown removes the scratch input, output, and log directories. The aggregate file is kept, and the next run rewrites it. No product code changes: the validator and role are unchanged. Signed-off-by: Mithilesh Reddy <mithilesh.reddy@dell.com>
balajikumaran-c-s
approved these changes
Nov 13, 2026
abhishek-sa1
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll check the actual working-tree state so the file list is accurate.
Only one file differs from HEAD, so the other changes may already be committed. I'll check the recent history.
The history shows a fold commit
f7debbe9f, which includes the role file. The role file is now identical to its pre-redirect version, so I'll check the net diff against the base commit to get the real file count.Net of the base commit
8acb63820, the PR changes two files. I'll write the description for those two only. Theartifactssweep is a third, uncommitted change, so I'm leaving it out.Description of the Solution
The IPoIB input FVT validates each case against a scratch project named
omnia_fvt_ipoib_<hex>. The validator writes its log under<OMNIA_DATA_PATH>/orchestrator/log/<scratch>/, and the teardown removed only the scratch input and output. Every run therefore left a newlog/omnia_fvt_ipoib_<hex>/directory that blocksomnia cleanup --all.This PR changes only the test code. After each validation, the FVT copies the scratch log into the active project's single validation log,
<OMNIA_DATA_PATH>/orchestrator/log/<project>/orchestrator_validation_<project>.log. The first case of a session rewrites that file, and later cases append to it, each under a header naming the scratch project. The teardown removes the scratch input, output, and log directories. The aggregate file is kept, and the next run rewrites it.Related Issue
Changes
IPoIB input FVT (
test/orchestrator/library/functions/ipoib_inputs_precheck_func.py)_read_livereturns alog_rootkey, derived from the resolved input directory as<shared>/log._append_remotewrites base64 chunks, truncating on the first write and appending after._fold_scratch_logcopieslog/<scratch>/orchestrator_validation_<scratch>.logintolog/<project>/orchestrator_validation_<project>.log. It creates the project directory withmkdir -pif needed, and returnsFalsewhen the scratch log is absent._AGGREGATE_LOG_STARTEDdecides whether the next write truncates or appends. It is set only after a log has been written._run_validateruns the clone and validation as before, folds the scratch log, and removes the scratch input, output, and log directories in thefinallyblock.IPoIB FVT constants (
test/orchestrator/library/vars/ipoib_vars.py)make_parent_dirscommand (mkdir -p -- %s).Files Changed
test/orchestrator/library/functions/ipoib_inputs_precheck_func.pytest/orchestrator/library/vars/ipoib_vars.pymake_parent_dirscommand.Testing
./run_validation.sh fvt_orchestrator precheck verify --suite ipoib_inputs.log/<project>/orchestrator_validation_<project>.logcontains a header and output for each case.omnia_fvt_ipoib_*directory remains under/opt/omnia/orchestrator/log/.log/<project>/is rewritten, not appended to, at the start of a new run.Backward Compatibility
orchestrator/log/and blockscleanup --alluntil removed.omnia_fvt_ipoib_*directories from earlier runs are not removed by this PR and need manual cleanup.