Open
Conversation
| let mut buf_vec = Vec::with_capacity(frame_count as usize * 32); | ||
|
|
||
| for &encoded in raw { | ||
| // We want the root->leaf order here (folded stacks are "root;...;leaf"). |
Contributor
There was a problem hiding this comment.
这里有个疑问，对应帧就是应该放在栈顶的吗？
Collaborator
Author
There was a problem hiding this comment.
是的，对应帧是调用栈栈顶，raw 是从当前执行帧开始回溯收集的（leaf → root）
但最终profiler.folded里是 root;...;leaf顺序，所以这里输出做了反转
Contributor
There was a problem hiding this comment.
我的意思是解释器栈帧（下图中黄色部分）和原生栈帧（其他部分），解释器栈帧是否预期是在栈顶，原生栈帧预期是在栈底？
Contributor
|
下面这种没有解释器栈帧的情况有没有定位到原因？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for:
Fixes "wrong lua frame display order"
Steps to reproduce the bug
Changes to fix the bug
Affected branches
Checklist