Use go 1.25.#516
Open
jholdstock wants to merge 5 commits into
Open
Conversation
As documented in the sync package, using WaitGroup.Go is now recommended over using .Add and .Done.
CSRF was not previously implemented in vspd because it would have required a bit of bodging: - Imported from gorilla/csrf with some kind of adapter to make it work for gin. - Imported from a gin specific package (eg. utrack/gin-csrf) which would pull in a bunch of new dependencies. - Implemented from scratch. None of the actions in the vspd API were sensitive enough to be worth this extra cruft, however this PR uses the implementation of CSRF protection which was added to stdlib in go 1.25, meaning it is free of the above compromises.
davecgh
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking advantage of a few features added in go 1.25, details in individual commits.