Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dev_module_build-and-registration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
MODULES_MODULE_TAG: ${{ github.event.inputs.tag }}
SOURCE_REPO: "${{secrets.SOURCE_REPO}}"
SOURCE_REPO_GIT: "${{secrets.SOURCE_REPO_GIT}}"
GO_VERSION: "1.24.13"
GO_VERSION: "1.25.8"
MODULE_EDITION: "EE"

on:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/dev_module_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ env:
MODULES_MODULE_SOURCE: ${{ vars.DEV_MODULE_SOURCE }}
MODULES_REGISTRY_LOGIN: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
MODULES_REGISTRY_PASSWORD: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
GO_VERSION: "1.24.13"
GOLANGCI_LINT_VERSION: "1.64.8"
GO_VERSION: "1.25.8"
GOLANGCI_LINT_VERSION: "2.11.1"
SOURCE_REPO: "${{secrets.SOURCE_REPO}}"
SOURCE_REPO_GIT: "${{secrets.SOURCE_REPO_GIT}}"
TRIVY_DISABLE_VEX_NOTICE: "true"
Expand Down Expand Up @@ -255,11 +255,11 @@ jobs:
find_errors=0
cd "$dir" || { echo "::error::Failed to access directory $dir"; continue; }
if ! output=$(golangci-lint run --sort-results); then
if ! output=$(golangci-lint run); then
error_count=$(( error_count + 1 ))
echo "::group::📂 Linting directory ❌: $dir"
echo -e "❌ Errors:\n$output\n"
golangci-lint run --sort-results || true
golangci-lint run || true
else
echo "::group::📂 Linting directory ✅: $dir"
echo -e "✅ All check passed\n"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/dev_validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
name: Validations

env:
GO_VERSION: "1.24.13"
GO_VERSION: "1.25.8"
on:
pull_request:
types: [opened, synchronize, labeled, unlabeled]
Expand Down Expand Up @@ -158,9 +158,9 @@ jobs:
matrix:
# Define two groups of components with their respective Go versions
components:
- { component: virtualization-artifact, go-version: "1.24.13" }
- { component: vm-route-forge, go-version: "1.24.13" }
- { component: api, go-version: "1.24.13" }
- { component: virtualization-artifact, go-version: "1.25.8" }
- { component: vm-route-forge, go-version: "1.25.8" }
- { component: api, go-version: "1.25.8" }

steps:
- name: Set skip flag
Expand Down
2 changes: 1 addition & 1 deletion api/client/examples/cancel-evacuation/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/deckhouse/virtualization/api/client/examples/cancel-evacuation

replace github.com/deckhouse/virtualization/api => ./../../../../api

go 1.24.13
go 1.25.8

require (
github.com/deckhouse/virtualization/api v0.0.0-00010101000000-000000000000
Expand Down
2 changes: 1 addition & 1 deletion api/client/examples/list-resources/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/deckhouse/virtualization/api/client/examples/list-resources

go 1.24.13
go 1.25.8

require (
github.com/deckhouse/virtualization/api v0.0.0-20240322104947-2d492906a8b2
Expand Down
2 changes: 1 addition & 1 deletion api/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/deckhouse/virtualization/api

go 1.24.13
go 1.25.8

tool (
k8s.io/code-generator
Expand Down
632 changes: 318 additions & 314 deletions build/base-images/deckhouse_images.yml

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions build/components/versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ firmware:
libvirt: v10.9.0
edk2: stable202411
core:
3p-kubevirt: v1.3.1-v12n.12-cse.4
3p-containerized-data-importer: v1.60.3-v12n.10-cse.4
3p-kubevirt: v1.3.1-v12n.12-cse.5
3p-containerized-data-importer: v1.60.3-v12n.10-cse.5
distribution: 2.8.3
package:
acl: v2.3.1
Expand Down
3 changes: 3 additions & 0 deletions images/base-alt-p11-binaries/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@ shell:
cp -af /$pkg/. /
rm -rf /$pkg
done
rm -f /var/lib/rpm/__db*
rpm -v --rebuilddb
2 changes: 1 addition & 1 deletion images/bounder/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ imageSpec:
---
image: {{ .ModuleNamePrefix }}{{ .ImageName }}-cbuilder
final: false
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-alt-1.24" "builder/golang-alt-svace-1.24" }}
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-alt-1.25" "builder/golang-alt-svace-1.25" }}
git:
- add: {{ .ModuleDir }}/images/{{ .ImageName }}/static_binaries
to: /static_binaries
Expand Down
4 changes: 2 additions & 2 deletions images/cdi-artifact/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ shell:
---
image: {{ .ModuleNamePrefix }}{{ .ImageName }}
final: false
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-alt-1.24" "builder/golang-alt-svace-1.24" }}
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-alt-1.25" "builder/golang-alt-svace-1.25" }}
mount:
- fromPath: ~/go-pkg-cache
to: /go/pkg
Expand Down Expand Up @@ -138,7 +138,7 @@ shell:
---
image: {{ .ModuleNamePrefix }}{{ .ImageName }}-cbuilder
final: false
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-bookworm-1.24" "builder/golang-alt-svace-1.24" }}
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-bookworm-1.25" "builder/golang-alt-svace-1.25" }}
git:
- add: {{ .ModuleDir }}/images/{{ .ImageName }}
to: /
Expand Down
162 changes: 117 additions & 45 deletions images/cdi-cloner/cloner-startup/.golangci.yaml
Original file line number Diff line number Diff line change
@@ -1,60 +1,132 @@
# https://golangci-lint.run/usage/configuration/
version: "2"

run:
concurrency: 4
timeout: 10m
# skip-dirs:
# this code has been copied from kubectl cli. No need to lint external code.
# - go_lib/dependency/k8s/drain
# this code has been copied from kubernetes vertical-pod-autoscaler. No need to lint external code.
# - modules/302-vertical-pod-autoscaler/hooks/internal/vertical-pod-autoscaler/v1

issues:
# Show all errors.
max-issues-per-linter: 0
max-same-issues: 0
exclude:
# - ST1005.*
- "don't use an underscore in package name"
# - "exported: .*"

linters-settings:
gofumpt:
extra-rules: true
gci:
sections:
- standard
- default
- prefix(github.com/deckhouse/)
goimports:
local-prefixes: github.com/deckhouse/
errcheck:
exclude-functions: fmt:.*,[rR]ead|[wW]rite|[cC]lose,io:Copy
revive:
rules:
- name: dot-imports
disabled: true
output:
sort-results: true

linters:
disable-all: true
exclusions:
paths:
- "^zz_generated.*"

formatters:
enable:
- asciicheck
- bidichk
- bodyclose
- dogsled
- errcheck
- errname
- errorlint
- gci
- gocritic
- gofmt
- gofumpt
- goimports
- gosimple
- govet
- ineffassign
- misspell
- nolintlint
- revive
- staticcheck
- typecheck
- unconvert
- unparam
- unused
- whitespace
settings:
gci:
sections:
- standard
- default
- prefix(github.com/deckhouse/)
gofumpt:
extra-rules: true
goimports:
local-prefixes: github.com/deckhouse/

linters:
default: none
enable:
- asciicheck # checks that your code does not contain non-ASCII identifiers
- bidichk # checks for dangerous unicode character sequences
- bodyclose # checks whether HTTP response body is closed successfully
- contextcheck # [maybe too many false positives] checks the function whether use a non-inherited context
- dogsled # checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
- errcheck # checking for unchecked errors, these unchecked errors can be critical bugs in some cases
- errname # checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error
- errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13
- copyloopvar # detects places where loop variables are copied (Go 1.22+)
- gocritic # provides diagnostics that check for bugs, performance and style issues
- govet # reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
- ineffassign # detects when assignments to existing variables are not used
- misspell # finds commonly misspelled English words in comments
- nolintlint # reports ill-formed or insufficient nolint directives
- reassign # checks that package variables are not reassigned
- revive # fast, configurable, extensible, flexible, and beautiful linter for Go, drop-in replacement of golint
- staticcheck # is a go vet on steroids, applying a ton of static analysis checks
- testifylint # checks usage of github.com/stretchr/testify
- unconvert # removes unnecessary type conversions
- unparam # reports unused function parameters
- unused # checks for unused constants, variables, functions and types
- usetesting # reports uses of functions with replacement inside the testing package
- testableexamples # checks if examples are testable (have an expected output)
- thelper # detects golang test helpers without t.Helper() call and checks the consistency of test helpers
- tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
- whitespace # detects leading and trailing whitespace
- wastedassign # finds wasted assignment statements
- importas # checks import aliases against the configured convention
settings:
errcheck:
exclude-functions:
- "(*os.File).Close"
- "(*net.TCPConn).Close"
- "(io.ReadCloser).Close"
- "(net.Listener).Close"
- "(net.Conn).Close"
- "(net.Conn).Close"
- "(*golang.org/x/crypto/ssh.Session).Close"
- "(*github.com/fsnotify/fsnotify.Watcher).Close"
staticcheck:
dot-import-whitelist:
- github.com/onsi/ginkgo/v2
- github.com/onsi/gomega
revive:
rules:
- name: dot-imports
disabled: true
- name: exported
disabled: true
- name: package-comments
disabled: true
nolintlint:
# Exclude following linters from requiring an explanation.
# Default: []
allow-no-explanation: [funlen, gocognit, lll]
# Enable to require an explanation of nonzero length after each nolint directive.
# Default: false
require-explanation: true
# Enable to require nolint directives to mention the specific linter being suppressed.
# Default: false
require-specific: true
importas:
# Do not allow unaliased imports of aliased packages.
# Default: false
no-unaliased: true
# Do not allow non-required aliases.
# Default: false
no-extra-aliases: false
# List of aliases
# Default: []
alias:
# - pkg: github.com/deckhouse/virtualization/api/core/v1alpha2
# alias: ""
# - pkg: github.com/deckhouse/virtualization/api/subresources/v1alpha2
# alias: subv1alpha2
# - pkg: kubevirt.io/api/core/v1
# alias: virtv1
- pkg: k8s.io/api/core/v1
alias: corev1
- pkg: k8s.io/api/authentication/v1
alias: authnv1
# - pkg: k8s.io/api/storage/v1
# alias: storagev1
- pkg: k8s.io/api/networking/v1
alias: netv1
- pkg: k8s.io/api/policy/v1
alias: policyv1
- pkg: k8s.io/apimachinery/pkg/apis/meta/v1
alias: metav1
- pkg: k8s.io/api/resource/v1
alias: resourcev1
2 changes: 1 addition & 1 deletion images/cdi-cloner/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ shell:
---
image: {{ .ModuleNamePrefix }}{{ .ImageName }}-gobuild
final: false
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-bookworm-1.24" "builder/golang-alt-svace-1.24" }}
fromImage: {{ eq $.SVACE_ENABLED "false" | ternary "builder/golang-bookworm-1.25" "builder/golang-alt-svace-1.25" }}
git:
- add: {{ .ModuleDir }}/images/{{ .ImageName }}/cloner-startup
to: /app
Expand Down
8 changes: 4 additions & 4 deletions images/debuger/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ import:
---
image: {{ $.ImageName }}-builder
final: false
fromImage: base-alt-p11-binaries
fromImage: builder/alt
shell:
install:
- |
apt-get update && apt-get install --yes \
musl-devel-static gcc golang git
musl-devel-static gcc golang git
export CGO_ENABLED=0
export GOOS=linux
export GOARCH=amd64
export GOARCH=amd64
mkdir -p /out
git clone --depth=1 --branch v1.25.1 https://github.com/go-delve/delve.git /src
Expand Down
2 changes: 1 addition & 1 deletion images/distroless/werf.inc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ imageSpec:
user: 64535
---
image: {{ .ModuleNamePrefix }}{{ .ImageName }}-artifact
fromImage: {{ .ModuleNamePrefix }}base-alt-p11-binaries
fromImage: builder/alt
final: false
shell:
beforeInstall:
Expand Down
Loading
Loading