fix devcontainer failed to start#477
Conversation
Co-authored-by: Simon Sawert <[email protected]>
bombsimon
left a comment
bombsimon
left a comment
There was a problem hiding this comment.
I'm no maintainer nor collaborator but maybe a review will help ease load of maintainer anyway!
Nice fix! 🎉
|
Awesome. Thanks a lot. I'll look into that shortly. 👍 |
There was a problem hiding this comment.
I wonder what's the reason for adding this file. The Dockefile doesn't copy anything from the .devcontainer directory anyways so this does nothing.
There was a problem hiding this comment.
You might be right.
normally the Dockerfile doesn't copy from .devcontainer. but I've noticed Codespaces sometimes rebuild the image when I completely stop and then start it. if there are changes in .devcontainer, even when I haven't changed the Dockerfile. That seemed to cause full rebuilds, so I added the dockerignore to try to prevent that.
dreamoutbox
left a comment
dreamoutbox
left a comment
There was a problem hiding this comment.
reply to review
3 participants
Fix the devcontainer failing to start in Codespaces and improve build performance.
Changes:
redis-sentinelimage tag indocker-composecargo-releaseandcargo-outdatedinstallation topostCreateCommand.dockerignoreto avoid unnecessary full Docker rebuildsCloses #476