Add support for multiple MFA devices - #17
Open
mmrwoods wants to merge 4 commits into
Open
Conversation
When multiple MFA devices found, ask user to choose which to use. Previously the first was used, and no info about the device was shown. The enquiries package was chosen for the prompt because it is simple. Normally I use inquirer for these things, but it seemed overkill here.
mmrwoods
force-pushed
the
feature/prompt-when-multiple-mfa-devices
branch
from
October 10, 2025 11:34
1e814a9 to
64e9d04
Compare
Switch from enquiries package to questionary, which works on Windows
mmrwoods
marked this pull request as draft
October 11, 2025 08:02
Fixes use of `eval $(awsmfa --env)` when user has multiple devices
mmrwoods
marked this pull request as ready for review
October 11, 2025 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple MFA devices found, ask user to choose which to use. Previously the first was used, and no info about the device was shown.
The enquiries package was chosen for the prompt because it is simple. Normally I use inquirer for these things, but it seemed overkill here.