dbeaver/pro#9532 Support user AI credentials - #4624
Open
yagudin10 wants to merge 29 commits into
Open
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 3 critical |
🟢 Metrics 407 complexity · 2 duplication
Metric Results Complexity 407 Duplication 2
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
force-pushed
the
dbeaver/pro#9532-user-ai-credentials
branch
from
September 8, 2026 14:54
243d74b to
3700a52
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are a few confirmed functional issues (session-credentials lookup, inconsistent profile scope state, and click bubbling causing unintended profile selection) that should be fixed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds per-user AI profile credentials support across the CloudBeaver stack: GraphQL exposes profile global/credentialsSaved and a credentials mutation; the server stores user credentials in private secret storage (with session fallback) and applies them only to effective runtime profiles; the frontend introduces new AI Profiles plugins and UI surfaces for managing/entering credentials in both administration and user profile/AI chat flows.
Changes:
- Introduced
aiSaveProfileCredentialsGraphQL mutation and extended AI profile fields (global,credentialsSaved) end-to-end (schema + core-sdk queries + frontend resources). - Added new frontend packages for AI profiles, administration UI, and user profile integration; refactored existing AI administration/chat to use shared profile resources.
- Implemented server-side user credential storage (secret storage + session fallback) and applied effective profiles during AI chat execution; added regression tests.
File summaries
| File | Description |
|---|---|
| webapp/yarn.lock | Updates workspace dependency graph to include new AI profile packages and TS CSS modules plugin. |
| webapp/packages/plugin-set-common/tsconfig.json | Adds TS project references for new AI profile packages. |
| webapp/packages/plugin-set-common/src/index.ts | Registers new AI profile modules in the common plugin set. |
| webapp/packages/plugin-set-common/package.json | Declares dependencies on new AI profile packages. |
| webapp/packages/plugin-ai/src/module.ts | Registers new AISettingsResource in plugin-ai DI. |
| webapp/packages/plugin-ai/src/index.ts | Exports AISettingsResource from plugin-ai public API. |
| webapp/packages/plugin-ai/src/AISettingsResource.ts | Adds shared resource for loading/saving AI settings via GraphQL. |
| webapp/packages/plugin-ai/package.json | Trims unused React/MobX deps from plugin-ai package. |
| webapp/packages/plugin-ai-user-profile/tsconfig.json | New TS project config for user-profile AI credentials UI package. |
| webapp/packages/plugin-ai-user-profile/src/module.ts | Registers user profile AI tab + credentials panel services and localization. |
| webapp/packages/plugin-ai-user-profile/src/LocaleService.ts | Adds locale provider for the new user-profile AI package. |
| webapp/packages/plugin-ai-user-profile/src/locales/zh.ts | Adds zh translations for user AI profiles UI. |
| webapp/packages/plugin-ai-user-profile/src/locales/ru.ts | Adds ru translations for user AI profiles UI. |
| webapp/packages/plugin-ai-user-profile/src/locales/fr.ts | Adds fr translations for user AI profiles UI. |
| webapp/packages/plugin-ai-user-profile/src/locales/en.ts | Adds en translations for user AI profiles UI. |
| webapp/packages/plugin-ai-user-profile/src/index.ts | New entrypoint for user-profile AI package. |
| webapp/packages/plugin-ai-user-profile/src/components/AIUserProfilesTable.tsx | Displays profiles with credential status and opens credentials editor. |
| webapp/packages/plugin-ai-user-profile/src/components/AIProfilesPanel.tsx | User profile panel to list/refresh available AI profiles. |
| webapp/packages/plugin-ai-user-profile/src/components/AIProfileCredentialsPanel.tsx | Options panel form wrapper for editing per-profile user credentials. |
| webapp/packages/plugin-ai-user-profile/src/components/AIProfileCredentialsFields.tsx | Credential input + reset action for a selected profile. |
| webapp/packages/plugin-ai-user-profile/src/AIUserProfileBootstrap.ts | Adds “AI Profiles” tab to user profile when available. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsPanelService.ts | Manages credentials panel open/close and unsaved-changes flow. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsForm/IAIProfileCredentialsFormState.ts | Defines form state shape for profile credentials editing. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsForm/IAIProfileCredentialsFormProps.ts | Defines form props type for credentials form. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsForm/getAIProfileCredentialsFormPart.ts | Wires credentials form part via data context/DI. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsForm/AIProfileCredentialsFormTabBootstrap.ts | Registers credentials tab/part in the credentials form. |
| webapp/packages/plugin-ai-user-profile/src/AIProfileCredentialsForm/AIProfileCredentialsFormPart.ts | Implements load/save logic for user token credentials. |
| webapp/packages/plugin-ai-user-profile/src/AI_PROFILES_TAB_ID.ts | Defines tab id constant for user “AI Profiles” tab. |
| webapp/packages/plugin-ai-user-profile/package.json | Adds new workspace package for user profile integration. |
| webapp/packages/plugin-ai-user-profile/.gitignore | Adds package-level ignores for build artifacts. |
| webapp/packages/plugin-ai-profiles/tsconfig.json | New TS project config for shared AI profiles package. |
| webapp/packages/plugin-ai-profiles/src/module.ts | Registers shared AI profiles resource, credentials dialog service, localization. |
| webapp/packages/plugin-ai-profiles/src/LocaleService.ts | Adds locale provider for shared AI profiles UI strings. |
| webapp/packages/plugin-ai-profiles/src/locales/zh.ts | Adds zh translations for shared AI profile UI/credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/locales/ru.ts | Adds ru translations for shared AI profile UI/credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/locales/fr.ts | Adds fr translations for shared AI profile UI/credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/locales/en.ts | Adds en translations for shared AI profile UI/credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/locales/de.ts | Adds de translations for shared AI profile UI/credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/index.ts | Exposes shared AI profiles APIs (resource/table/credentials dialog). |
| webapp/packages/plugin-ai-profiles/src/AIProfilesTableLazy.ts | Adds lazy import wrapper for shared profiles table. |
| webapp/packages/plugin-ai-profiles/src/AIProfilesTable.tsx | Shared profiles table component (scope + selection + click behaviors). |
| webapp/packages/plugin-ai-profiles/src/AIProfilesTable.module.css | Styling for shared profiles table. |
| webapp/packages/plugin-ai-profiles/src/AIProfilesResource.ts | Frontend resource for profiles list + saving/resetting user credentials. |
| webapp/packages/plugin-ai-profiles/src/AIProfileCredentials/IAIProfileCredentialsDialogPayload.ts | Dialog payload type for credentials dialog. |
| webapp/packages/plugin-ai-profiles/src/AIProfileCredentials/AIProfileCredentialsUtils.ts | Helpers to detect whether user credentials are supported/required. |
| webapp/packages/plugin-ai-profiles/src/AIProfileCredentials/AIProfileCredentialsService.ts | Service to open credentials dialog and determine support/requiredness. |
| webapp/packages/plugin-ai-profiles/src/AIProfileCredentials/AIProfileCredentialsDialogLazy.ts | Lazy wrapper for credentials dialog component. |
| webapp/packages/plugin-ai-profiles/src/AIProfileCredentials/AIProfileCredentialsDialog.tsx | Credentials dialog UI and save/reset flows. |
| webapp/packages/plugin-ai-profiles/src/AI_PROFILES_TABLE_ROW_HEIGHT.ts | Shared constant for table row height. |
| webapp/packages/plugin-ai-profiles/package.json | Adds new workspace package for shared AI profiles primitives. |
| webapp/packages/plugin-ai-profiles/.gitignore | Adds package-level ignore for build output. |
| webapp/packages/plugin-ai-profiles-administration/tsconfig.json | New TS project config for AI profiles administration UI package. |
| webapp/packages/plugin-ai-profiles-administration/src/module.ts | Registers admin profiles UI bootstraps/resources/services. |
| webapp/packages/plugin-ai-profiles-administration/src/LocaleService.ts | Adds locale provider for admin profiles UI package. |
| webapp/packages/plugin-ai-profiles-administration/src/locales/ru.ts | Adds ru translations for admin profiles UI. |
| webapp/packages/plugin-ai-profiles-administration/src/locales/fr.ts | Adds fr translations for admin profiles UI. |
| webapp/packages/plugin-ai-profiles-administration/src/locales/en.ts | Adds en translations for admin profiles UI. |
| webapp/packages/plugin-ai-profiles-administration/src/locales/de.ts | Adds de translations for admin profiles UI. |
| webapp/packages/plugin-ai-profiles-administration/src/index.ts | New entrypoint exporting admin bootstrap. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfilesTabPanel.tsx | Admin tab panel wrapper for profiles UI. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfilesAdministrationBootstrap.ts | Adds “Profiles” sub-tab into AI administration navigation. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/utils/prepareProperties.ts | Builds minimal changed property map and filters password placeholders. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/utils/getObjectPropertiesValues.ts | Converts property info arrays into object value maps. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/useAIProfilesTable.ts | Table actions (delete confirmation includes credential deletion warning). |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfilesToolsPanel.module.css | Styles for admin profiles tools panel. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfilesPanel.tsx | Refactors admin profiles panel to use shared profiles/settings resources. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfilesAdministrationTable.tsx | Uses shared AIProfilesTable for administration listing. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/getAIProfileFormPart.ts | Injects shared AIProfilesResource + credentials service into form part. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/AIProfileSchema.ts | Extends profile schema with global flag. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/AIProfilePropertiesForm.tsx | Extracted reusable properties form wrapper. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/AIProfileOptions.tsx | Adds scope selector and adjusts model/property handling for user credentials profiles. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/AIProfileFormPart.ts | Handles global/user scope state, validation, and config mapping for profile save. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/IAIProfileFormState.ts | Defines form state for admin profile editor. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/IAIProfileFormProps.ts | Defines props typing for admin profile form. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/AIProfileFormTabBootstrap.ts | Registers “options” tab for admin profile form panel. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/AIProfileFormService.ts | Adds admin profile form service using options panel + unsaved changes confirmation. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/AIProfileFormPanel.tsx | Adjusts save UX (close panel after successful create). |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/AIProfileForm.tsx | Adds lazy-loaded admin profile form container. |
| webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIEnginePropertiesResource.ts | Adds loadModels API to engine properties resource. |
| webapp/packages/plugin-ai-profiles-administration/package.json | Adds new workspace package for AI profiles administration UI. |
| webapp/packages/plugin-ai-profiles-administration/.gitignore | Adds package-level ignore for build output. |
| webapp/packages/plugin-ai-chat/tsconfig.json | Adds reference to shared AI profiles package. |
| webapp/packages/plugin-ai-chat/src/module.ts | Removes now-redundant AIChatProfilesResource registration. |
| webapp/packages/plugin-ai-chat/src/locales/zh.ts | Adds translations for “edit credentials” in chat profile menu. |
| webapp/packages/plugin-ai-chat/src/locales/ru.ts | Adds translations for “edit credentials” in chat profile menu. |
| webapp/packages/plugin-ai-chat/src/locales/it.ts | Adds translations for “edit credentials” in chat profile menu. |
| webapp/packages/plugin-ai-chat/src/locales/en.ts | Adds translations for “edit credentials” in chat profile menu. |
| webapp/packages/plugin-ai-chat/src/AIChatProfilesResource.ts | Removes deprecated chat-specific profiles resource. |
| webapp/packages/plugin-ai-chat/src/AIChat/AIChatMessage/AIChatMessageService.ts | Prompts for credentials when required before sending message. |
| webapp/packages/plugin-ai-chat/src/AIChat/AIChatConversation/AIChatConversationsResource.ts | Outdates conversations when referenced profiles are deleted. |
| webapp/packages/plugin-ai-chat/src/AIChat/AIChatConversation/AIChatConversationScope/AIChatConversationScope.tsx | Uses shared AI profiles resource to populate profile list. |
| webapp/packages/plugin-ai-chat/src/AIChat/AIChatConversation/AIChatConversationScope/AIChatConversationProfile.tsx | Adds credentials prompt/edit UI per profile in chat menu. |
| webapp/packages/plugin-ai-chat/package.json | Adds dependency on shared AI profiles package. |
| webapp/packages/plugin-ai-administration/tsconfig.json | Updates references to use shared AI profiles package. |
| webapp/packages/plugin-ai-administration/src/module.ts | Removes AI profiles/settings resources from AI admin module (now shared packages). |
| webapp/packages/plugin-ai-administration/src/locales/ru.ts | Removes profile-management translations now owned by profiles admin package. |
| webapp/packages/plugin-ai-administration/src/locales/fr.ts | Removes profile-management translations now owned by profiles admin package. |
| webapp/packages/plugin-ai-administration/src/locales/en.ts | Removes profile-management translations now owned by profiles admin package. |
| webapp/packages/plugin-ai-administration/src/locales/de.ts | Removes profile-management translations now owned by profiles admin package. |
| webapp/packages/plugin-ai-administration/src/index.ts | Exports AISettingsService from plugin-ai-administration. |
| webapp/packages/plugin-ai-administration/src/AISettingsService.ts | Minor typing improvement (dispose(): void). |
| webapp/packages/plugin-ai-administration/src/AISettingsResource.ts | Removes old admin-only settings resource (moved to plugin-ai). |
| webapp/packages/plugin-ai-administration/src/AISettingsForm/getAdministrationAISettingsFormInfoPart.ts | Switches to shared AI settings/profiles resources. |
| webapp/packages/plugin-ai-administration/src/AISettingsForm/AdministrationAISettingsInfoPart.ts | Switches to shared AI settings/profiles resources. |
| webapp/packages/plugin-ai-administration/src/AIProfiles/AIProfilesTable.tsx | Removes old admin profiles table implementation (replaced by shared one). |
| webapp/packages/plugin-ai-administration/src/AIProfiles/AIProfilesResource.ts | Removes old admin profiles resource (replaced by shared one). |
| webapp/packages/plugin-ai-administration/src/AIAdministrationTabsService.ts | Removes old profiles tab wiring from base AI administration package. |
| webapp/packages/plugin-ai-administration/src/AIAdministrationProfilesTabPanel.tsx | Removes old profiles tab panel. |
| webapp/packages/plugin-ai-administration/src/AIAdministrationPage.tsx | Switches to shared AI profiles resource. |
| webapp/packages/plugin-ai-administration/package.json | Replaces deps with shared AI profiles package; adds CSS modules TS plugin. |
| webapp/packages/core-sdk/src/queries/ai/updateAiProfile.gql | Adds global to updated admin profile result selection. |
| webapp/packages/core-sdk/src/queries/ai/saveAiProfileCredentials.gql | Adds credentials mutation operation. |
| webapp/packages/core-sdk/src/queries/ai/getAiProfiles.gql | Adds global and credentialsSaved to profile list query. |
| webapp/packages/core-sdk/src/queries/ai/createAiProfile.gql | Adds global to created admin profile result selection. |
| webapp/packages/core-blocks/src/FormControls/RadioGroup.tsx | Improves RadioGroup labeling support (label/labelledBy/aria-label). |
| webapp/packages/core-blocks/src/FormControls/RadioGroup.module.css | Adds label styling for RadioGroup when using label. |
| webapp/common-react/@dbeaver/react-data-grid/src/DataGridHeaderCellContext.ts | Extends DataGrid header context with getHeaderMinWidth. |
| webapp/common-react/@dbeaver/react-data-grid/src/DataGrid.tsx | Threads getHeaderMinWidth into column minWidth. |
| server/test/io.cloudbeaver.test.platform/src/io/cloudbeaver/test/platform/CEServerTestSuite.java | Adds new AI credentials regression test to CE test suite. |
| server/test/io.cloudbeaver.test.platform/src/io/cloudbeaver/service/ai/WebAIProfileCredentialsTest.java | New unit test covering saving/updating/clearing credentials + session fallback. |
| server/test/io.cloudbeaver.test.platform/META-INF/MANIFEST.MF | Adds AI service bundle dependency for new tests. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/WebAIUtils.java | Applies effective profile (with user credentials) and validates configuration per conversation. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/WebAIProfileCredentials.java | Implements per-user AI profile credential storage and effective profile resolution. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/model/WebAIConfigurationProfile.java | Exposes global and credentialsSaved for GraphQL profile info. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/model/inputs/WebAIProfileCredentialsInput.java | Adds GraphQL input model for profile credentials properties. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/gql/WebServiceBindingAI.java | Binds GraphQL mutation aiSaveProfileCredentials. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/gql/WebServiceAI.java | Implements credentials mutation + applies effective profile in AI flows; cleans up credentials on profile changes/deletes. |
| server/bundles/io.cloudbeaver.service.ai/src/io/cloudbeaver/service/ai/gql/DBWServiceAI.java | Adds service interface method for saving profile credentials (secure parameter). |
| server/bundles/io.cloudbeaver.service.ai/schema/service.ai.graphqls | Extends schema with global/credentialsSaved and credentials mutation input/field. |
| server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/WebUserContext.java | Fixes synchronization/initialization guard for secret controller. |
| server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/app/VoidSecretController.java | Updates copyright year and ensures secret controller reports 0 features. |
Review details
Suppressed comments (1)
webapp/packages/plugin-ai-profiles-administration/src/AIProfiles/AIProfileForm/Options/AIProfileFormPart.ts:91
- When user credentials are not supported,
changeEngineforcesthis.state.global = truebut doesn’t updatethis.state.properties.globalaccordingly. This can leave state inconsistent (e.g., radio shows “global” while properties still containglobal: false) and may affect dirty-state detection and subsequent saves/model loads.
- Files reviewed: 121/131 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+222
to
+230
| SessionCredentials sessionCredentials = webSession.getAttribute(attribute); | ||
| if (sessionCredentials != null && sessionCredentials.profile() == profile) { | ||
| if (create) { | ||
| return sessionCredentials.credentials(); | ||
| } | ||
| synchronized (sessionCredentials.credentials()) { | ||
| return Map.copyOf(sessionCredentials.credentials()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#9532
Summary
Testing