Skip to content

Conversation

@Antzelino
Copy link
Contributor

Description

Implements #1118

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).
  • I ran uv run ruff check && uv run ruff format && uv run mypy --install-types . to lint and format the code.

adds an unreachable return, because `uv run mypy --install-types .` complains about a missing return statement in this method, even though there is a `self.fail` before it.
mypy now complained about unreachable statement, reverting previous commit 01b8149
@Antzelino
Copy link
Contributor Author

Also an extra comment, in the README.md, under Configuration and Usage it's mentioned that information on configuring mycli is in https://www.mycli.net/config

Of course I cannot add this new information there, so I was wondering if it could be added from someone who can on the website as well, otherwise I don't see how users would know to use this new user setting. Thank you.

@rolandwalker
Copy link
Contributor

Hi! Thanks! Is there a different way we could name the configuration option favorite_query_show_query?

It seems awkward to say "query" twice: favorites_show_query? favorite_query_show?

@Antzelino
Copy link
Contributor Author

I agree, I changed it to show_favorite_query 👍

Thank you, I'm looking forward to this! Have been using mycli for about 3 years for work and wanted this change but hadn't gotten around to trying to implement it myself 😅 Finally I'm attempting my first OSS contribution here!

@rolandwalker rolandwalker merged commit c14557d into dbcli:main Jan 8, 2026
8 checks passed
@rolandwalker
Copy link
Contributor

my first OSS contribution

Awesome! Welcome to the club!

@Antzelino Antzelino deleted the antzelino/favorite-query-show-option-1118 branch January 8, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants