ipc: expose surface_content_rect in get_tree#340
Open
jbms wants to merge 5 commits into
Open
Conversation
This change fixes several runtime memory leaks in the compositor and swaybar,
and introduces a cleaner strategy for handling exit-time leaks under
LeakSanitizer (LSan) without requiring verbose shutdown-only cleanup code.
Runtime Leak Fixes:
- Compositor:
- Free temporary file list in `cmd_include` when processing `include` commands.
- Free `font_description` in `free_config` during config reloads.
- End seat operations in `handle_seat_destroy` to free seatop-specific state.
- Swaybar:
- Free `status->buffer` in `status_line_free` to avoid leaking the status line on updates.
Exit-Time Leak Strategy:
Instead of adding extensive code to traverse and free all global structures
(like container trees) at shutdown just to satisfy LSan, we run LSan checks
early before these structures are orphaned:
- Compositor:
- Manually invoke `__lsan_do_leak_check()` in `main.c` after `server_fini()`
has completed but before `root_destroy` or `free_config` are called.
- Prior to the leak check, clean up `pango`, `cairo`, and `fontconfig`
global static caches to avoid false positives.
- Since the global pointers `root` and `config` are still intact when LSan
runs, LSan correctly treats these structures as reachable rather than leaked,
allowing us to still run `root_destroy` and `free_config` afterwards
unconditionally.
- Added direct dependency on `fontconfig` in Meson build files to support direct calls to `FcFini()`.
- Swaybar:
- Wrap library cleanups and manual LSan invocation in `#ifdef __SANITIZE_ADDRESS__`
after `bar_teardown` in `main.c`.
- Add targeted LSan suppressions in `tests/lsan.supp` for exit-only DBus slot
allocations in the tray (`create_watcher`, `init_host`, etc.) that are not
worth cleaning up at shutdown.
Introduce new Lua APIs to query animation status and progress. Also includes testing infrastructure and tests: - Added `tests/test_leak_two_clients.py` to check for runtime leaks with clients active. - Added `tests/test_shutdown_events.py` and `tests/test_shutdown_lua_callbacks.py` to verify shutdown behavior and Lua callbacks. - Added `test_normal_exit_with_bar` to `tests/test_normal_exit.py` to ensure `scrollbar` is covered by LSan checks during normal shutdown.
jbms
force-pushed
the
ipc-surface-content-rect
branch
from
66e8eb6 to
f38f23c
Compare
Owner
|
|
Contributor
Author
|
I think the |
Expose the actual view geometry (as set by the client via xdg-shell set_window_geometry) in the IPC get_tree output as 'surface_content_rect'. This is useful for clients using protocols like ext-image-copy-capture-v1 to capture foreign windows. Since the capture contains the full window surface (including Client-Side Decorations, shadows, etc.), the client needs to know the offset of the actual window content within the captured image. The surface_content_rect field exposes this offset (x, y) and size (width, height) relative to the surface.
Owner
|
OK, so you don't want coordinates to capture a part of the frame buffer like you would do with |
Owner
|
Is this for your project? Do you want to use the client buffer to create a static image for your suspended applications? If that is the case, I will merge it, but I have no way to test this otherwise. Most applications simply get the whole frame buffer and use |
jbms
force-pushed
the
ipc-surface-content-rect
branch
from
f38f23c to
b1221c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the actual view geometry (as set by the client via xdg-shell set_window_geometry) in the IPC get_tree output as 'surface_content_rect'.
This is useful for clients using protocols like ext-image-copy-capture-v1 to capture foreign windows. Since the capture contains the full window surface (including Client-Side Decorations, shadows, etc.), the client needs to know the offset of the actual window content within the captured image. The surface_content_rect field exposes this offset (x, y) and size (width, height) relative to the surface.