Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

build sass-variables.js in preBuild, not postBuild - #3

Open
kielni wants to merge 1 commit into
davidpett:masterfrom
kielni:pre-build
Open

kielni wants to merge 1 commit into
davidpett:masterfrom
kielni:pre-build

Conversation

@kielni

@kielni kielni commented Jul 21, 2017

Copy link
Copy Markdown

generate sass-variables.js before the build so it will be included in the dist output

building in postBuild doesn't work for CI:

  • run ember test
  • builds project to dist
  • generates utils/sass-variables.js
  • runs tests with code from dist, but utils/sass-variables.js not in that build because it didn't exist yet

it works for development (with ember server) because touching the file causes a rebuild
it works for production if a previous build (ember test) created the file

generate sass-variables.js before the build so it will be included in the dist output

building in postBuild doesn't work for CI:
- run ember test
- builds project to dist
- generates utils/sass-variables.js
- runs tests with code from dist, but utils/sass-variables.js not in that build because it didn't exist yet

it works for development (with `ember server`) because touching the file causes a rebuild
it works for production if a previous build (`ember test`) created the file

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant